From 359587b4ae44e3f800a02e420324e390835f8480 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 27 Feb 2026 08:09:24 +0100 Subject: [PATCH] update: stop running icon extraction for the 'archive' section Do not extract icons in archive, they have not been used there in a very long time, if ever. And if so, only in specific cases. --- fdroidserver/update.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index efbee7ee..f7f52f6d 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -2206,13 +2206,13 @@ def process_apk(apkcache, apkfilename, repodir, package_added_cache, use_date_fr .format(apkfilename=apkfilename)) return True, None, False - # extract icons from APK zip file - iconfilename = get_old_icon_filename(apk['packageName'], apk['versionCode']) - with zipfile.ZipFile(apkfile, 'r') as apkzip: - empty_densities = extract_apk_icons(iconfilename, apk, apkzip, repodir) - - # resize existing icons for densities missing in the APK - fill_missing_icon_densities(empty_densities, iconfilename, apk, repodir) + # Do not extract icons in archive, they have not been used there + # in a very long time, if ever. And if so, only in specific cases. + if repodir == 'repo': + iconfilename = get_old_icon_filename(apk['packageName'], apk['versionCode']) + with zipfile.ZipFile(apkfile, 'r') as apkzip: + empty_densities = extract_apk_icons(iconfilename, apk, apkzip, repodir) + fill_missing_icon_densities(empty_densities, iconfilename, apk, repodir) apk['added'] = package_added_cache.get(apkfile, use_date_from_apk)