From 8362108ec14654f53d3d52dfd23a88855f2e5aaa Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Wed, 3 Dec 2025 18:39:10 +0100 Subject: [PATCH] checkupdates: only run tests on GNU/Linux checkupdates is only ever run in production on Debian and it often fails elsewhere. https://gitlab.com/fdroid/fdroidserver/-/jobs/12307572200 --- tests/test_checkupdates.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/test_checkupdates.py b/tests/test_checkupdates.py index 4cc76db3..7c4640bd 100755 --- a/tests/test_checkupdates.py +++ b/tests/test_checkupdates.py @@ -2,7 +2,6 @@ import git import os -import platform import shutil import tempfile import time @@ -17,6 +16,10 @@ import fdroidserver.checkupdates basedir = Path(__file__).parent +@unittest.skipUnless( + os.path.exists('/usr/bin/dpkg'), # easy test for "Debian-ish" + 'checkupdates is only ever run in production on Debian.', +) class CheckupdatesTest(unittest.TestCase): '''fdroidserver/checkupdates.py''' @@ -491,10 +494,6 @@ class CheckupdatesTest(unittest.TestCase): fdroidserver.checkupdates.main() sys_exit.assert_not_called() - @unittest.skipIf( - platform.system() == 'Darwin', - 'It is difficult to configure the base system for this test.', - ) def test_get_upstream_main_branch(self): os.chdir(self.testdir.name) testvalue = 'foo'