From 85c1bd48367d5f7333b8ea239e372ae230b824b3 Mon Sep 17 00:00:00 2001
From: Austin <vidplace7@gmail.com>
Date: Fri, 31 Jul 2026 20:28:01 -0400
Subject: [PATCH] Address STM32 cppcheck warnings (#11314)

- Suppress GenericThreadModule warning when DEBUG_MUTE
- Suppress warning stemming from check_skip_packages
- Cast pointers to uint32_t before subtracting to avoid cppcheck warning
---
 src/Power.cpp                       | 3 +++
 src/memGet.cpp                      | 5 ++++-
 src/modules/GenericThreadModule.cpp | 3 +++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/Power.cpp b/src/Power.cpp
index a886082c60..e43fe77c9d 100644
--- a/src/Power.cpp
+++ b/src/Power.cpp
@@ -61,6 +61,9 @@
 #define LL_ADC_RESOLUTION LL_ADC_DS_DATA_WIDTH_12_BIT
 #define BATTERY_SENSE_RESOLUTION_BITS 12
 #else
+// The ST HAL headers that define these are outside cppcheck's include path (check_skip_packages), so static
+// analysis always lands here even though real builds resolve one of the branches above.
+// cppcheck-suppress preprocessorErrorDirective
 #error "ADC resolution could not be defined!"
 #endif
 #define ADC_RANGE (1 << BATTERY_SENSE_RESOLUTION_BITS)
diff --git a/src/memGet.cpp b/src/memGet.cpp
index 2da93bf125..49d1953c25 100644
--- a/src/memGet.cpp
+++ b/src/memGet.cpp
@@ -23,7 +23,10 @@ static uint32_t sbrkHeadroom()
     extern char _estack;
     extern char _Min_Stack_Size;
 
-    uint32_t max_sp = (uint32_t)(&_estack - &_Min_Stack_Size);
+    // Both are linker-script symbols rather than real objects: _estack is the top-of-RAM address and
+    // _Min_Stack_Size is a plain value. Convert each to an integer before subtracting - differencing the
+    // pointers themselves is pointer arithmetic across unrelated objects.
+    uint32_t max_sp = (uint32_t)&_estack - (uint32_t)&_Min_Stack_Size;
     uint32_t heap_end = (uint32_t)sbrk(0);
     return (max_sp > heap_end) ? (max_sp - heap_end) : 0;
 }
diff --git a/src/modules/GenericThreadModule.cpp b/src/modules/GenericThreadModule.cpp
index eb92566bde..28b9ff7824 100644
--- a/src/modules/GenericThreadModule.cpp
+++ b/src/modules/GenericThreadModule.cpp
@@ -17,6 +17,9 @@ int32_t GenericThreadModule::runOnce()
     if (!enabled)
         return disable();
 
+    // Sample first-run gate: the body is where custom one-shot init goes. With logging compiled out (e.g.
+    // DEBUG_MUTE) only the flag assignment is left, which cppcheck reads as a redundant condition.
+    // cppcheck-suppress duplicateConditionalAssign
     if (firstTime) {
         // do something the first time we run
         firstTime = 0;