From b2e862006dd41165eb3771b5fe453bd6bc7c8a5a Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 8 Apr 2026 20:15:25 +0000
Subject: [PATCH] Remove OSThread inheritance from AtakPluginModule - pure
 passthrough needs no periodic scheduling

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/bdc82eb6-77c4-4711-839c-04bcbb1aa9cd

Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
---
 src/modules/AtakPluginModule.cpp | 11 +----------
 src/modules/AtakPluginModule.h   |  5 +----
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/src/modules/AtakPluginModule.cpp b/src/modules/AtakPluginModule.cpp
index ce8e60f5a..bfe820223 100644
--- a/src/modules/AtakPluginModule.cpp
+++ b/src/modules/AtakPluginModule.cpp
@@ -1,21 +1,12 @@
 #include "AtakPluginModule.h"
-#include "Default.h"
-#include "MeshService.h"
-#include "configuration.h"
-#include "main.h"
 
 AtakPluginModule *atakPluginModule;
 
 AtakPluginModule::AtakPluginModule()
-    : SinglePortModule("atak", meshtastic_PortNum_ATAK_PLUGIN_V2), concurrency::OSThread("AtakPlugin")
+    : SinglePortModule("atak", meshtastic_PortNum_ATAK_PLUGIN_V2)
 {
 }
 
-int32_t AtakPluginModule::runOnce()
-{
-    return default_broadcast_interval_secs * 1000;
-}
-
 ProcessMessage AtakPluginModule::handleReceived(const meshtastic_MeshPacket &mp)
 {
     (void)mp; // Passthrough — no processing needed, apps handle compression/decompression
diff --git a/src/modules/AtakPluginModule.h b/src/modules/AtakPluginModule.h
index 02ab86746..cd9ca293c 100644
--- a/src/modules/AtakPluginModule.h
+++ b/src/modules/AtakPluginModule.h
@@ -1,6 +1,5 @@
 #pragma once
 #include "SinglePortModule.h"
-#include "concurrency/OSThread.h"
 
 /**
  * ATAK Plugin V2 module - passthrough for ATAK_PLUGIN_V2 payloads.
@@ -10,7 +9,7 @@
  * (Android, iOS, ATAK plugin); firmware forwards the bytes unchanged on the
  * ATAK_PLUGIN_V2 port.
  */
-class AtakPluginModule : public SinglePortModule, private concurrency::OSThread
+class AtakPluginModule : public SinglePortModule
 {
   public:
     /** Constructor
@@ -20,8 +19,6 @@ class AtakPluginModule : public SinglePortModule, private concurrency::OSThread
 
   protected:
     virtual ProcessMessage handleReceived(const meshtastic_MeshPacket &mp) override;
-    /* Does our periodic broadcast */
-    int32_t runOnce() override;
 };
 
 extern AtakPluginModule *atakPluginModule;