From ee48094ea8309858cd579100b8aaf14560bcc4b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20G=C3=B6ttgens?= Date: Mon, 24 Aug 2026 11:29:54 +0200 Subject: [PATCH] Fix backwards GPS_RX_PIN/GPS_TX_PIN direction comments (#11585) GPS.cpp passes GPS_RX_PIN as the MCU's RX pin and GPS_TX_PIN as its TX pin. Nine variants documented the opposite, which reads as if the pins were swapped on working hardware (see #11584). Comment-only change; no pin assignment is touched. --- variants/esp32s3/ELECROW-ThinkNode-M5/variant.h | 4 ++-- variants/esp32s3/heltec_v4/variant.h | 6 +++--- variants/esp32s3/heltec_v4_r8/variant.h | 6 +++--- variants/nrf52840/heltec_mesh_node_t096/variant.h | 4 ++-- variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h | 4 ++-- variants/nrf52840/heltec_mesh_node_t114/variant.h | 4 ++-- variants/nrf52840/heltec_mesh_solar/variant.h | 4 ++-- variants/nrf52840/meshlink/variant.h | 4 ++-- variants/nrf52840/t-echo/variant.h | 4 ++-- 9 files changed, 20 insertions(+), 20 deletions(-) diff --git a/variants/esp32s3/ELECROW-ThinkNode-M5/variant.h b/variants/esp32s3/ELECROW-ThinkNode-M5/variant.h index ee86c3df60..e1e2676843 100644 --- a/variants/esp32s3/ELECROW-ThinkNode-M5/variant.h +++ b/variants/esp32s3/ELECROW-ThinkNode-M5/variant.h @@ -45,8 +45,8 @@ #define PIN_GPS_STANDBY 11 // An output to wake GPS, low means allow sleep, high means force wake -#define GPS_TX_PIN 20 // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN 19 // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN 20 // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN 19 // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/esp32s3/heltec_v4/variant.h b/variants/esp32s3/heltec_v4/variant.h index e9c19888a8..33f885f607 100644 --- a/variants/esp32s3/heltec_v4/variant.h +++ b/variants/esp32s3/heltec_v4/variant.h @@ -92,7 +92,7 @@ #define PERIPHERAL_WARMUP_MS 1000 // Make sure I2C QuickLink has stable power before continuing #define PIN_GPS_STANDBY (40) // An output to wake GPS, low means allow sleep, high means force wake #define PIN_GPS_PPS (41) -// Seems to be missing on this new board -#define GPS_TX_PIN (38) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (39) // This is for bits going TOWARDS the GPS +// GNSS is on the V4 expansion kit (CM121, 9600 baud by default), not on the bare board +#define GPS_TX_PIN (38) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (39) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/esp32s3/heltec_v4_r8/variant.h b/variants/esp32s3/heltec_v4_r8/variant.h index 31bfd0ac59..52357f07de 100644 --- a/variants/esp32s3/heltec_v4_r8/variant.h +++ b/variants/esp32s3/heltec_v4_r8/variant.h @@ -64,7 +64,7 @@ #define GPS_EN_ACTIVE LOW #define PERIPHERAL_WARMUP_MS 1000 // Make sure I2C QuickLink has stable power before continuing #define PIN_GPS_PPS (41) -// Seems to be missing on this new board -#define GPS_TX_PIN (38) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (39) // This is for bits going TOWARDS the GPS +// GNSS is on the V4 expansion kit (CM121, 9600 baud by default), not on the bare board +#define GPS_TX_PIN (38) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (39) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/heltec_mesh_node_t096/variant.h b/variants/nrf52840/heltec_mesh_node_t096/variant.h index 67a8c235ca..3fa9dd86d3 100644 --- a/variants/nrf52840/heltec_mesh_node_t096/variant.h +++ b/variants/nrf52840/heltec_mesh_node_t096/variant.h @@ -161,8 +161,8 @@ No longer populated on PCB #define GPS_EN_ACTIVE LOW #define PERIPHERAL_WARMUP_MS 1000 // Make sure I2C QuickLink has stable power before continuing #define PIN_GPS_PPS (32 + 11) -#define GPS_TX_PIN (0 + 25) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (0 + 23) // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN (0 + 25) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (0 + 23) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h b/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h index 2802e4c1dc..9ddd069159 100644 --- a/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h +++ b/variants/nrf52840/heltec_mesh_node_t114-inkhud/variant.h @@ -115,8 +115,8 @@ No longer populated on PCB #define PIN_GPS_PPS (32 + 4) // Seems to be missing on this new board // #define PIN_GPS_PPS (32 + 4) // Pulse per second input from the GPS -#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/heltec_mesh_node_t114/variant.h b/variants/nrf52840/heltec_mesh_node_t114/variant.h index e5f45a2425..a9588d04f8 100644 --- a/variants/nrf52840/heltec_mesh_node_t114/variant.h +++ b/variants/nrf52840/heltec_mesh_node_t114/variant.h @@ -171,8 +171,8 @@ No longer populated on PCB #define PIN_GPS_PPS (32 + 4) // Seems to be missing on this new board // #define PIN_GPS_PPS (32 + 4) // Pulse per second input from the GPS -#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/heltec_mesh_solar/variant.h b/variants/nrf52840/heltec_mesh_solar/variant.h index 8d4db4bea8..2ebc416099 100644 --- a/variants/nrf52840/heltec_mesh_solar/variant.h +++ b/variants/nrf52840/heltec_mesh_solar/variant.h @@ -115,8 +115,8 @@ No longer populated on PCB #define PIN_GPS_PPS (32 + 4) // Seems to be missing on this new board // #define PIN_GPS_PPS (32 + 4) // Pulse per second input from the GPS -#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN (32 + 7) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (32 + 5) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/meshlink/variant.h b/variants/nrf52840/meshlink/variant.h index 00107ac347..11f56eac82 100644 --- a/variants/nrf52840/meshlink/variant.h +++ b/variants/nrf52840/meshlink/variant.h @@ -120,8 +120,8 @@ static const uint8_t SCK = PIN_SPI_SCK; #define PIN_GPS_PPS (26) // Pulse per second input from the GPS -#define GPS_TX_PIN PIN_SERIAL1_TX // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN PIN_SERIAL1_RX // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN PIN_SERIAL1_TX // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN PIN_SERIAL1_RX // This is for bits going TOWARDS the CPU // #define GPS_THREAD_INTERVAL 50 diff --git a/variants/nrf52840/t-echo/variant.h b/variants/nrf52840/t-echo/variant.h index f4644c6dee..09a5673acc 100644 --- a/variants/nrf52840/t-echo/variant.h +++ b/variants/nrf52840/t-echo/variant.h @@ -177,8 +177,8 @@ External serial flash WP25R1635FZUIL0 #define PIN_GPS_STANDBY (32 + 2) // An output to wake GPS, low means allow sleep, high means force wake // Seems to be missing on this new board #define PIN_GPS_PPS (32 + 4) // Pulse per second input from the GPS -#define GPS_TX_PIN (32 + 8) // This is for bits going TOWARDS the CPU -#define GPS_RX_PIN (32 + 9) // This is for bits going TOWARDS the GPS +#define GPS_TX_PIN (32 + 8) // This is for bits going TOWARDS the GPS +#define GPS_RX_PIN (32 + 9) // This is for bits going TOWARDS the CPU #define GPS_THREAD_INTERVAL 50