Commit Graph
2 Commits
Author SHA1 Message Date
Claude 2b85dbdbeb portduino Sensors: address review findings
- Read the command sensor after the INA219/260/3221, MAX17048 and RAK
  readers in getEnvironmentTelemetry(). Those ran after the sensors list
  and overwrote a configured voltage or current command.
- Drop a reading whose scaled value is not finite (value * Scale can
  overflow), so inf is never sent and never reaches an integer cast.
- A non-finite Scale (.inf, .nan) falls back to 1; --check warns.
- An empty `Sensors:` is skipped like any other empty section. A normal
  boot rejected it as "not a list" while --check called it clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011C7D9dE4aUYBrGdpPyHs25
2026-11-02 20:54:37 +00:00
Claude fc2fc97730 portduino: read environment telemetry from shell commands (Sensors:)
Add a Sensors: list to config.yaml. Each entry names an EnvironmentMetrics
field and a shell command that prints one number:

  Sensors:
    - Type: temperature
      Command: cat /sys/bus/iio/devices/iio:device0/in_temp_input
      Scale: 0.001

- CommandSensor plugs into EnvironmentTelemetryModule like the T1000x
  sensor (no I2C device). Readings are cached for 30s, since getMetrics()
  also runs for screen refreshes and phone requests. Output that is not
  exactly one finite number is logged and the field is left unset.
  Integer fields are rounded and clamped.
- Type matches the protobuf field name, case-insensitively. An unknown
  Type or missing Command stops meshtasticd, as Security.AdminKeys does.
  Entries append across config.d files.
- exec() now has a timeout: commands run in their own process group,
  stdin is /dev/null, and the whole group is killed at the deadline, so
  a hung script stalls the main loop for a bounded time. Command sensors
  get 2s; HostMetrics and other exec() callers get 10s. Output is capped
  at 4 KiB. Windows keeps popen() without a timeout.
- --check validates the section (type, command, scale, unknown keys,
  duplicate types) and notes that sensors need environment measurement
  enabled. Boot logs a warning when sensors are configured but
  environment measurement is off. The section does not enable telemetry
  itself, because enabling it also broadcasts to the mesh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011C7D9dE4aUYBrGdpPyHs25
2026-11-02 13:51:33 +00:00