mirror of
https://github.com/meshtastic/firmware.git
synced 2026-11-07 14:54:44 -05:00
Jonathan BennettandClaude Opus 5
2cf97c1b64
A push to membrowse/membrowse-action's v1 tag today shipped an action.yml that
uses ${{ github.workspace }} in the `description:` of its new source_root input.
Expressions are evaluated in the `inputs:` section too, and the github context
does not exist there, so the runner refuses to load the manifest:
membrowse/membrowse-action/v1/action.yml (Line: 77, Col: 18):
Unrecognized named-value: 'github'
Every membrowse job now fails in "Set up job", before any of our steps run, and
build_firmware.yml's membrowse job feeds ci-gate - so the required check is red
on every PR in the repo.
Pin both references to 34719bdb0472, the SHA v1 resolved to on the last green
run (membrowse 1.2.15, 03:34 UTC today), which also stops a third-party tag
move from reaching us unannounced again. comment-action/action.yml is identical
at both SHAs; pinning it is for consistency, not because it broke.
The repo's own size enforcement is unaffected either way: size-budget-gate
reads the manifest-* artifacts from pio-build, not anything MemBrowse produces.
Claude-Session: https://claude.ai/code/session_01JjAvRt6xuztC3hKqWkW9Dw
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
37 lines
1.2 KiB
YAML
37 lines
1.2 KiB
YAML
name: Post MemBrowse Comment
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: [CI]
|
|
types: [completed]
|
|
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
|
|
jobs:
|
|
post-membrowse-comment:
|
|
# Skipped CI runs upload nothing, so the summary lookup would 404.
|
|
if: >
|
|
github.repository == 'meshtastic/firmware' &&
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
github.event.workflow_run.conclusion != 'cancelled' &&
|
|
github.event.workflow_run.conclusion != 'skipped'
|
|
continue-on-error: true
|
|
runs-on: ubuntu-26.04
|
|
steps:
|
|
# Only for gh to resolve the repo from the git remote; gh authenticates with GH_TOKEN.
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Post combined PR comment
|
|
# Same repo, same reason as the pin in membrowse_report.yml - keep the two together.
|
|
uses: membrowse/membrowse-action/comment-action@34719bdb04722be5cbe9c1d6df4a1567ae98238d
|
|
# gh posts the comment; without a token it fails and the action only logs a warning.
|
|
env:
|
|
GH_TOKEN: ${{ github.token }}
|
|
with:
|
|
api_key: ${{ secrets.MEMBROWSE_API_KEY }}
|
|
commit: ${{ github.event.workflow_run.head_sha }}
|