mirror of
https://github.com/meshtastic/firmware.git
synced 2026-09-16 16:41:24 -04:00
* logging: gate LOG_TRACE behind MESHTASTIC_TRACE_LOGGING, drop redundant reclock logs LOG_TRACE now compiles out by default so trace-level diagnostics cost no flash; enable with -DMESHTASTIC_TRACE_LOGGING. Portduino keeps it on for the traceFilename packet-trace feature. Remove the 66 caller-side I2C reclock/restore log lines in the telemetry sensors: ReClockI2C::setClock/restoreClock already log both frequencies internally (now at trace level, since they fire every sensor read). Also unify near-duplicate literals (colon/case/punctuation variants) so linker string dedup applies, and drop an information-free bare 'done'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * logging: demote chatty per-packet/per-poll DEBUG lines to trace level With LOG_TRACE compiled out by default, per-iteration chatter (packet bookkeeping, sensor poll values, e-ink refresh reasons, GPS pin states, UI runState traces) now costs no flash on device builds while remaining one -DMESHTASTIC_TRACE_LOGGING away. 108 lines demoted, 4 information- free lines removed; failure paths, drop reasons, and one-time init logs all stay at debug level. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * logging: address CodeRabbit review on trace-gate PR - GPS: pass serial-derived buffers as %s args, never as format strings (untrusted bytes could contain % directives) - 0x%08x for packet id / NodeNum per convention (Router, CannedMessage, NeighborInfo); unsigned casts for size_t args; %u for uint32_t delta - EInk: async full-refresh begin/complete back to DEBUG (rare state transitions); per-frame SKIPPED lines stay trace Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * logging: gate trace on the flag's value, not its presence -DMESHTASTIC_TRACE_LOGGING=0 previously *enabled* trace logging because the gate tested definedness. The flag now defaults per-platform (portduino 1, else 0) and both backends test the value, so =0 disables, =1 or a bare -D enables. Also cast tx_after-millis() to uint32_t for %u (millis() is unsigned long on native). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * logging: clang-format rewrap after specifier widening Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * Even fewer bytes! * logging: keep compile-gated debug lines at debug level; fix native-suite-count Lines already inside default-off #ifdef blocks (GPS_DEBUG, DEBUG_LOOP_TIMING) cost no flash and should stay visible at debug level when their gate is enabled, rather than also requiring MESHTASTIC_TRACE_LOGGING. test/native-suite-count lags the two test_event_channel_* suites added by #11045 (develop's Native Suite Count check has the same mismatch); bump 46 -> 47. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 * gps: route GPS_DEBUG diagnostics through a LOG_DEBUG_GPS() macro (#11414) Replaces 27 log-only #ifdef GPS_DEBUG blocks across GPS.cpp, PositionModule, MeshService, and GPSStatus.h with a single-line LOG_DEBUG_GPS() call (src/gps/GPSLog.h, modeled on LOG_MIGRATION: value-gated, ((void)0) when off). Blocks containing declarations, control flow, hexDump, or nested conditionals keep an explicit '#if GPS_DEBUG' guard. RTC.cpp's per-reading raw time dumps and per-candidate rejection chatter fold under the same gate; quality transitions and boot-time seeding stay at debug. Also fixes the '// define GPS_DEBUG' missing-# typo in two variant headers and updates all seven commented examples to the value form ('#define GPS_DEBUG 1') required by the value-based gate. Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 Co-authored-by: Claude <noreply@anthropic.com> * gps: declare RTC gmtime result as pointer to const (cppcheck) With the setTime debug dump gated behind GPS_DEBUG, all remaining uses of t are reads; cppcheck (constVariablePointer) now flags it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBiZc9sfPrH1MZ2L3Fxgt1 --------- Co-authored-by: Claude <noreply@anthropic.com>
229 lines
7.9 KiB
C++
229 lines
7.9 KiB
C++
#pragma once
|
|
|
|
#include "configuration.h"
|
|
|
|
// Forward declarations
|
|
#if defined(DEBUG_HEAP)
|
|
class MemGet;
|
|
extern MemGet memGet;
|
|
#endif
|
|
|
|
// DEBUG LED
|
|
#ifndef LED_STATE_ON
|
|
#define LED_STATE_ON 1
|
|
#endif
|
|
|
|
// WIFI LED
|
|
#ifndef WIFI_STATE_ON
|
|
#define WIFI_STATE_ON 1
|
|
#endif
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// DEBUG
|
|
// -----------------------------------------------------------------------------
|
|
|
|
#ifdef CONSOLE_MAX_BAUD
|
|
#define SERIAL_BAUD CONSOLE_MAX_BAUD
|
|
#else
|
|
#define SERIAL_BAUD 115200 // Serial debug baud rate
|
|
#endif
|
|
|
|
#define MESHTASTIC_LOG_LEVEL_DEBUG "DEBUG"
|
|
#define MESHTASTIC_LOG_LEVEL_INFO "INFO "
|
|
#define MESHTASTIC_LOG_LEVEL_WARN "WARN "
|
|
#define MESHTASTIC_LOG_LEVEL_ERROR "ERROR"
|
|
#define MESHTASTIC_LOG_LEVEL_CRIT "CRIT "
|
|
#define MESHTASTIC_LOG_LEVEL_TRACE "TRACE"
|
|
#define MESHTASTIC_LOG_LEVEL_HEAP "HEAP"
|
|
|
|
#include "SerialConsole.h"
|
|
|
|
// If defined we will include support for ARM ICE "semihosting" for a virtual
|
|
// console over the JTAG port (to replace the normal serial port)
|
|
// Note: Normally this flag is passed into the gcc commandline by platformio.ini.
|
|
// for an example see env:rak4631_dap.
|
|
// #ifndef USE_SEMIHOSTING
|
|
// #define USE_SEMIHOSTING
|
|
// #endif
|
|
|
|
#define DEBUG_PORT (*console) // Serial debug port
|
|
|
|
// LOG_TRACE costs no flash unless enabled: -DMESHTASTIC_TRACE_LOGGING(=1) turns it on, =0 forces it off.
|
|
// Default is on only for portduino (traceFilename packet traces, logoutputlevel=trace), off elsewhere.
|
|
#ifndef MESHTASTIC_TRACE_LOGGING
|
|
#ifdef ARCH_PORTDUINO
|
|
#define MESHTASTIC_TRACE_LOGGING 1
|
|
#else
|
|
#define MESHTASTIC_TRACE_LOGGING 0
|
|
#endif
|
|
#endif
|
|
|
|
#ifdef USE_SEGGER
|
|
// #undef DEBUG_PORT
|
|
#define LOG_DEBUG(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#define LOG_INFO(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#define LOG_WARN(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#define LOG_ERROR(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#define LOG_CRIT(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#if MESHTASTIC_TRACE_LOGGING
|
|
#define LOG_TRACE(...) SEGGER_RTT_printf(0, __VA_ARGS__)
|
|
#else
|
|
#define LOG_TRACE(...)
|
|
#endif
|
|
#else
|
|
#if defined(DEBUG_PORT) && !defined(DEBUG_MUTE)
|
|
#define LOG_DEBUG(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_DEBUG, __VA_ARGS__)
|
|
#define LOG_INFO(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_INFO, __VA_ARGS__)
|
|
#define LOG_WARN(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_WARN, __VA_ARGS__)
|
|
#define LOG_ERROR(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_ERROR, __VA_ARGS__)
|
|
#define LOG_CRIT(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_CRIT, __VA_ARGS__)
|
|
#if MESHTASTIC_TRACE_LOGGING
|
|
#define LOG_TRACE(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_TRACE, __VA_ARGS__)
|
|
#else
|
|
#define LOG_TRACE(...)
|
|
#endif
|
|
#else
|
|
#define LOG_DEBUG(...)
|
|
#define LOG_INFO(...)
|
|
#define LOG_WARN(...)
|
|
#define LOG_ERROR(...)
|
|
#define LOG_CRIT(...)
|
|
#define LOG_TRACE(...)
|
|
#endif
|
|
#endif
|
|
|
|
#if defined(DEBUG_HEAP)
|
|
#define LOG_HEAP(...) DEBUG_PORT.log(MESHTASTIC_LOG_LEVEL_HEAP, __VA_ARGS__)
|
|
|
|
// Macro-based heap debugging
|
|
#define DEBUG_HEAP_BEFORE auto heapBefore = memGet.getFreeHeap();
|
|
#define DEBUG_HEAP_AFTER(context, ptr) \
|
|
do { \
|
|
auto heapAfter = memGet.getFreeHeap(); \
|
|
if (heapBefore != heapAfter) { \
|
|
LOG_HEAP("Alloc in %s pointer 0x%x, size: %u, free: %u", context, ptr, heapBefore - heapAfter, heapAfter); \
|
|
} \
|
|
} while (0)
|
|
|
|
#else
|
|
#define LOG_HEAP(...)
|
|
#define DEBUG_HEAP_BEFORE
|
|
#define DEBUG_HEAP_AFTER(context, ptr)
|
|
#endif
|
|
|
|
/// A C wrapper for LOG_DEBUG that can be used from arduino C libs that don't know about C++ or meshtastic
|
|
extern "C" void logLegacy(const char *level, const char *fmt, ...);
|
|
|
|
#define SYSLOG_NILVALUE "-"
|
|
|
|
#define SYSLOG_CRIT 2 /* critical conditions */
|
|
#define SYSLOG_ERR 3 /* error conditions */
|
|
#define SYSLOG_WARN 4 /* warning conditions */
|
|
#define SYSLOG_INFO 6 /* informational */
|
|
#define SYSLOG_DEBUG 7 /* debug-level messages */
|
|
// trace does not go out to syslog (yet?)
|
|
|
|
#define LOG_PRIMASK 0x07 /* mask to extract priority part (internal) */
|
|
/* extract priority */
|
|
#define LOG_PRI(p) ((p)&LOG_PRIMASK)
|
|
#define LOG_MAKEPRI(fac, pri) (((fac) << 3) | (pri))
|
|
|
|
/* facility codes */
|
|
#define LOGLEVEL_KERN (0 << 3) /* kernel messages */
|
|
#define LOGLEVEL_USER (1 << 3) /* random user-level messages */
|
|
#define LOGLEVEL_MAIL (2 << 3) /* mail system */
|
|
#define LOGLEVEL_DAEMON (3 << 3) /* system daemons */
|
|
#define LOGLEVEL_AUTH (4 << 3) /* security/authorization messages */
|
|
#define LOGLEVEL_SYSLOG (5 << 3) /* messages generated internally by syslogd */
|
|
#define LOGLEVEL_LPR (6 << 3) /* line printer subsystem */
|
|
#define LOGLEVEL_NEWS (7 << 3) /* network news subsystem */
|
|
#define LOGLEVEL_UUCP (8 << 3) /* UUCP subsystem */
|
|
#define LOGLEVEL_CRON (9 << 3) /* clock daemon */
|
|
#define LOGLEVEL_AUTHPRIV (10 << 3) /* security/authorization messages (private) */
|
|
#define LOGLEVEL_FTP (11 << 3) /* ftp daemon */
|
|
|
|
/* other codes through 15 reserved for system use */
|
|
#define LOGLEVEL_LOCAL0 (16 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL1 (17 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL2 (18 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL3 (19 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL4 (20 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL5 (21 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL6 (22 << 3) /* reserved for local use */
|
|
#define LOGLEVEL_LOCAL7 (23 << 3) /* reserved for local use */
|
|
|
|
#define LOG_NFACILITIES 24 /* current number of facilities */
|
|
#define LOG_FACMASK 0x03f8 /* mask to extract facility part */
|
|
/* facility of pri */
|
|
#define LOG_FAC(p) (((p)&LOG_FACMASK) >> 3)
|
|
|
|
#define LOG_MASK(pri) (1 << (pri)) /* mask for one priority */
|
|
#define LOG_UPTO(pri) ((1 << ((pri) + 1)) - 1) /* all priorities through pri */
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// AXP192 (Rev1-specific options)
|
|
// -----------------------------------------------------------------------------
|
|
|
|
#define GPS_POWER_CTRL_CH 3
|
|
#define LORA_POWER_CTRL_CH 2
|
|
|
|
// Default Bluetooth PIN
|
|
#define defaultBLEPin 123456
|
|
|
|
#if HAS_ETHERNET && defined(USE_ARDUINO_ETHERNET)
|
|
#include <Ethernet.h> // arduino-libraries/Ethernet - supports W5500 auto-detect
|
|
#elif HAS_ETHERNET && defined(USE_CH390D)
|
|
#include <ESP32_CH390.h>
|
|
#elif HAS_ETHERNET && !defined(USE_WS5500)
|
|
#include <RAK13800_W5100S.h>
|
|
#endif // HAS_ETHERNET
|
|
|
|
#if HAS_ETHERNET && defined(ARCH_ESP32)
|
|
#include <ETH.h>
|
|
#endif // HAS_ETHERNET
|
|
|
|
#if HAS_WIFI
|
|
#include <WiFi.h>
|
|
#endif // HAS_WIFI
|
|
|
|
#if HAS_NETWORKING
|
|
|
|
namespace meshtastic
|
|
{
|
|
class Syslog
|
|
{
|
|
private:
|
|
UDP *_client;
|
|
IPAddress _ip;
|
|
const char *_server;
|
|
uint16_t _port;
|
|
const char *_deviceHostname;
|
|
const char *_appName;
|
|
uint16_t _priDefault;
|
|
uint8_t _priMask = 0xff;
|
|
bool _enabled = false;
|
|
|
|
bool _sendLog(uint16_t pri, const char *appName, const char *message);
|
|
|
|
public:
|
|
explicit Syslog(UDP &client);
|
|
|
|
Syslog &server(const char *server, uint16_t port);
|
|
Syslog &server(IPAddress ip, uint16_t port);
|
|
Syslog &deviceHostname(const char *deviceHostname);
|
|
Syslog &appName(const char *appName);
|
|
Syslog &defaultPriority(uint16_t pri = LOGLEVEL_KERN);
|
|
Syslog &logMask(uint8_t priMask);
|
|
|
|
void enable();
|
|
void disable();
|
|
bool isEnabled();
|
|
|
|
bool vlogf(uint16_t pri, const char *fmt, va_list args) __attribute__((format(printf, 3, 0)));
|
|
bool vlogf(uint16_t pri, const char *appName, const char *fmt, va_list args) __attribute__((format(printf, 3, 0)));
|
|
};
|
|
|
|
}; // namespace meshtastic
|
|
|
|
#endif // HAS_NETWORKING
|