From 0cd65edc8bc36c5159f62539a74229bdb6b1bafc Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 15 Aug 2017 12:24:01 +0100 Subject: [PATCH] builder/module: Drop some unreachable code use_builddir is TRUE if meson is TRUE, so there can never be a meson case in the !use_builddir case. Coverity issue: 1452428 Signed-off-by: Philip Withnall --- builder/builder-module.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/builder/builder-module.c b/builder/builder-module.c index e01909b3..04b6834f 100644 --- a/builder/builder-module.c +++ b/builder/builder-module.c @@ -1461,13 +1461,9 @@ builder_module_build (BuilderModule *self, configure_cmd = "cmake"; configure_final_arg = g_strdup ("."); } - else if (meson) - { - g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, "module %s: Meson does not support building in sourcedir, set \"builddir\" to true.", self->name); - return FALSE; - } - else + else { + g_assert (!meson); configure_cmd = "./configure"; } }