transaction: Pinned packages override metadata autodelete directive

Browse Source

If both org.gnome.Sdk and org.gnome.Sdk.Docs are manually installed,
they have no dependents, and only org.gnome.Sdk.Docs is left pinned,
`flatpak uninstall --unused` should remove org.gnome.Sdk and all its
unused dependecies while keeping org.gnome.Sdk.Docs installed.

However, Flatpak still removes org.gnome.Sdk.Docs if org.gnome.Sdk's
metadata contains:

[Extension org.gnome.Sdk.Docs]
autodelete = true

This patch ensures that pinned packages will override the autodelete
metadata directive.  In this case, org.gnome.Sdk.Docs is spared from
uninstallation.

Thanks to Sebastian Wick (@swick) for reviewing the patch, and
suggesting variable initialization outside the loop that calls
flatpak_dir_ref_is_pinned():
https://github.com/flatpak/flatpak/pull/6859#pullrequestreview-5586932172

...

This commit is contained in:

500 Internal Server Error

Gitea Version: 1.28.0+dev-477-g8b6ad49a5f