From 1e093116217de064f4d5179e992a4a115edf6cce Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sat, 23 Apr 2022 16:10:54 +0100 Subject: [PATCH] workflows: Explicitly enable/disable GObject-Introspection For the build that uses --enable-asan, explicitly disable introspection, since the GObject-Introspection scanner works poorly with libtool and AddressSanitizer (see #4844); the only reason this worked until now is that --enable-asan doesn't currently do anything (again, see #4844). For the build that runs tests under valgrind, we already can't use AddressSanitizer, making this a good place to explicitly enable introspection, so that we have at least one build with it enabled. Signed-off-by: Simon McVittie --- .github/workflows/check.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 41517d8d..4c894990 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -65,10 +65,12 @@ jobs: - name: autogen.sh run: NOCONFIGURE=1 ./autogen.sh - name: configure + # We don't do gtk-doc or GObject-Introspection here, because they can + # clash with AddressSanitizer. Instead, the clang build enables those. run: | mkdir _build pushd _build - ../configure --enable-internal-checks --enable-asan + ../configure --enable-internal-checks --enable-asan --disable-introspection popd env: CFLAGS: -O2 -Wp,-D_FORTIFY_SOURCE=2 @@ -172,7 +174,7 @@ jobs: run: | mkdir _build pushd _build - ../configure --enable-gtk-doc --enable-gtk-doc-html + ../configure --enable-gtk-doc --enable-gtk-doc-html --enable-introspection popd env: CFLAGS: -O2