From 1f35dda1b50cceb24c471b19ac886dc91bf8a0b4 Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Wed, 6 Nov 2019 20:27:35 +0000 Subject: [PATCH] parental-controls: fix read of uninitialized variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If content_rating == NULL, then no value will be assigned to appdata_value, but its value will be used anyway – if it happens to be non-NULL, it will be dereferenced. common/flatpak-parental-controls.c: In function ‘flatpak_oars_check_rating’: common/flatpak-parental-controls.c:121:10: warning: ‘appdata_value’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (appdata_value != NULL) ^ --- common/flatpak-parental-controls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/flatpak-parental-controls.c b/common/flatpak-parental-controls.c index e1f4c77d..c7815678 100644 --- a/common/flatpak-parental-controls.c +++ b/common/flatpak-parental-controls.c @@ -113,7 +113,7 @@ flatpak_oars_check_rating (GHashTable *content_rating, MctAppFilterOarsValue rating_value; MctAppFilterOarsValue filter_value = mct_app_filter_get_oars_value (filter, oars_sections[i]); - const gchar *appdata_value; + const gchar *appdata_value = NULL; if (content_rating != NULL) appdata_value = g_hash_table_lookup (content_rating, oars_sections[i]);