mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-03-11 03:27:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

portal: Negative handles are an error

Browse Source 
Always treat a negative handle as being out-of-range.

Signed-off-by: Simon McVittie <smcv@collabora.com>
This commit is contained in:
Simon McVittie
2020-12-08 17:57:01 +00:00
committed by Alexander Larsson
parent 5562c921e8
commit 1fb8a68020
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
portal/flatpak-portal.c
View File

@@ -919,7 +919,7 @@ handle_spawn (PortalFlatpak *object,
g_variant_get_child (arg_fds, i, "{uh}", &dest_fd, &handle);
if (handle >= fds_len)
if (handle >= fds_len || handle < 0)
{
g_dbus_method_invocation_return_error (invocation, G_DBUS_ERROR,
G_DBUS_ERROR_INVALID_ARGS,
@@ -1138,7 +1138,7 @@ handle_spawn (PortalFlatpak *object,
{
gint32 handle;
g_variant_get_child (sandbox_expose_fd, i, "h", &handle);
if (handle < fds_len)
if (handle >= 0 && handle < fds_len)
{
int handle_fd = fds[handle];
g_autofree char *path = NULL;
@@ -1166,7 +1166,7 @@ handle_spawn (PortalFlatpak *object,
{
gint32 handle;
g_variant_get_child (sandbox_expose_fd_ro, i, "h", &handle);
if (handle < fds_len)
if (handle >= 0 && handle < fds_len)
{
int handle_fd = fds[handle];
g_autofree char *path = NULL;