mirror/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-05-15 12:04:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

history: Use uid_t and g_ascii_strtoull for UID parsing

Browse Source 
UIDs are unsigned; using signed strtoll and int can mishandle
high UIDs such as those used by systemd dynamic users.
This commit is contained in:
razzeee
2026-05-04 17:30:54 +02:00
committed by Sebastian Wick
parent 68ffa487ee
commit 250516b059
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/flatpak-builtins-history.c
View File

@@ -303,13 +303,13 @@ print_history (GPtrArray *dirs,
{
g_autofree char *id = get_field (j, "_UID", error);
g_autofree char *oid = NULL;
int uid;
uid_t uid;
struct passwd *pwd;
if (*error)
return FALSE;
uid = g_ascii_strtoll (id, NULL, 10);
uid = (uid_t) g_ascii_strtoull (id, NULL, 10);
pwd = getpwuid (uid);
if (pwd)
{
@@ -322,7 +322,7 @@ print_history (GPtrArray *dirs,
{
/* flatpak-system-helper acting on behalf of sb else */
g_autofree char *str = NULL;
uid = g_ascii_strtoll (oid, NULL, 10);
uid = (uid_t) g_ascii_strtoull (oid, NULL, 10);
pwd = getpwuid (uid);
str = g_strdup_printf ("%s (%s)", id, pwd ? pwd->pw_name : oid);
flatpak_table_printer_add_column (printer, str);