From 2804cd41167c2f17758bdb3049a538a08db1fc8e Mon Sep 17 00:00:00 2001
From: Dor Askayo <dor.askayo@gmail.com>
Date: Mon, 18 Sep 2023 00:18:07 +0300
Subject: [PATCH] utils: Add flatpak_parse_env_block()

This function can be used to parse environment variable blocks in
"env -0" format from a buffer. It performs a few format checks during
its parsing and returns an error if an issue is found.

When successful, it returns a string array containing each individual
environment variable parsed from the buffer, in the same format as
the return value of g_get_environ().

The implementation of this function is based on
flatpak_context_parse_env_block().
---
 common/flatpak-utils-private.h |  4 ++++
 common/flatpak-utils.c         | 42 ++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/common/flatpak-utils-private.h b/common/flatpak-utils-private.h
index 3e442f3a..6187c48a 100644
--- a/common/flatpak-utils-private.h
+++ b/common/flatpak-utils-private.h
@@ -693,6 +693,10 @@ null_safe_g_ptr_array_unref (gpointer data)
   g_clear_pointer (&data, g_ptr_array_unref);
 }
 
+GStrv flatpak_parse_env_block (const char  *data,
+                               gsize        length,
+                               GError     **error);
+
 int flatpak_envp_cmp (const void *p1,
                       const void *p2);
 
diff --git a/common/flatpak-utils.c b/common/flatpak-utils.c
index 30512a8a..7c2c60f2 100644
--- a/common/flatpak-utils.c
+++ b/common/flatpak-utils.c
@@ -7791,6 +7791,48 @@ flatpak_dconf_path_is_similar (const char *path1,
   return (path1[i1] == '\0');
 }
 
+GStrv
+flatpak_parse_env_block (const char  *data,
+                         gsize        length,
+                         GError     **error)
+{
+  g_autoptr(GPtrArray) env_vars = g_ptr_array_new_with_free_func (g_free);
+  const char *p = data;
+  gsize remaining = length;
+
+  /* env_block might not be \0-terminated */
+  while (remaining > 0)
+    {
+      size_t len = strnlen (p, remaining);
+      const char *equals;
+
+      g_assert (len <= remaining);
+
+      equals = memchr (p, '=', len);
+
+      if (equals == NULL || equals == p)
+        return glnx_null_throw (error,
+                                "Environment variable must be in the form VARIABLE=VALUE, not %.*s", (int) len, p);
+
+      g_ptr_array_add (env_vars,
+                       g_strndup (p, len));
+
+      p += len;
+      remaining -= len;
+
+      if (remaining > 0)
+        {
+          g_assert (*p == '\0');
+          p += 1;
+          remaining -= 1;
+        }
+    }
+
+  g_ptr_array_add (env_vars, NULL);
+
+  return (GStrv) g_ptr_array_free (g_steal_pointer (&env_vars), FALSE);
+}
+
 /**
  * flatpak_envp_cmp:
  * @p1: a `const char * const *`