From 3071d2ada975ac7b7e934fd689758d476865edee Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 16 Apr 2021 10:39:11 +0100 Subject: [PATCH] quiet-transaction: Remove unnecessary finalize This hasn't done anything useful since 0978826c: it just takes a new ref to the installation, and then releases that ref without doing anything with it. Detected by scan-build. Signed-off-by: Simon McVittie --- app/flatpak-quiet-transaction.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/app/flatpak-quiet-transaction.c b/app/flatpak-quiet-transaction.c index 432254be..e0f059ef 100644 --- a/app/flatpak-quiet-transaction.c +++ b/app/flatpak-quiet-transaction.c @@ -259,17 +259,6 @@ flatpak_quiet_transaction_run (FlatpakTransaction *transaction, return TRUE; } -static void -flatpak_quiet_transaction_finalize (GObject *object) -{ - FlatpakQuietTransaction *self = FLATPAK_QUIET_TRANSACTION (object); - g_autoptr(FlatpakInstallation) installation = NULL; - - installation = flatpak_transaction_get_installation (FLATPAK_TRANSACTION (self)); - - G_OBJECT_CLASS (flatpak_quiet_transaction_parent_class)->finalize (object); -} - static void flatpak_quiet_transaction_init (FlatpakQuietTransaction *transaction) { @@ -278,10 +267,8 @@ flatpak_quiet_transaction_init (FlatpakQuietTransaction *transaction) static void flatpak_quiet_transaction_class_init (FlatpakQuietTransactionClass *class) { - GObjectClass *object_class = G_OBJECT_CLASS (class); FlatpakTransactionClass *transaction_class = FLATPAK_TRANSACTION_CLASS (class); - object_class->finalize = flatpak_quiet_transaction_finalize; transaction_class->choose_remote_for_ref = choose_remote_for_ref; transaction_class->add_new_remote = add_new_remote; transaction_class->new_operation = new_operation;