From 333e0518c9493425a4a875332b68da9eb772425f Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Thu, 8 Oct 2020 15:26:03 +0200 Subject: [PATCH] transaction: Fix error handling in authentication failures We were not correctly returning in case of error, which caused a cascading "owerwrite gerror" problem. (cherry picked from commit 33d1d7b1a5853516b80ba422b49b7e49262a4b41) --- common/flatpak-transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/flatpak-transaction.c b/common/flatpak-transaction.c index 7dce5edf..ddf54547 100644 --- a/common/flatpak-transaction.c +++ b/common/flatpak-transaction.c @@ -3262,7 +3262,7 @@ request_tokens_for_remote (FlatpakTransaction *self, if (g_variant_lookup (results, "error-code", "i", &error_code) && error_code != -1) { if (error_message) - flatpak_fail_error (error, error_code, _("Failed to get tokens for ref: %s"), error_message); + return flatpak_fail_error (error, error_code, _("Failed to get tokens for ref: %s"), error_message); else return flatpak_fail_error (error, error_code, _("Failed to get tokens for ref")); }