From 3fc47aa0d3aa6cb61973df898ea58dca5c3cbced Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sun, 12 Jun 2016 09:59:34 +0100 Subject: [PATCH] Link libselinux into bwrap (if enabled) with LDADD, not LDFLAGS As explained in bubblewrap commit f6ca3690, libraries should always go in LDADD and not LDFLAGS, because the order of arguments to the linker matters. Many distributions' linkers are tolerant enough that it doesn't matter in practice, but it matters for static linking, and it might also matter on Ubuntu. Signed-off-by: Simon McVittie --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 88148ac8..cd3c8c8b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -82,7 +82,7 @@ include tests/Makefile.am.inc bwrap_PROGRAMS = flatpak-bwrap flatpak_bwrap_SOURCES = $(bwrap_SOURCES) flatpak_bwrap_CFLAGS = $(bwrap_CFLAGS) -flatpak_bwrap_LDFLAGS = $(bwrap_LDFLAGS) +flatpak_bwrap_LDADD = $(bwrap_LDADD) bwrapdir = $(libexecdir) include bubblewrap/Makefile-bwrap.am.inc