From 4ac11066908ddb62a456c8dbdfa11cce643e9e11 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 12 Jan 2021 10:09:18 +0000 Subject: [PATCH] portal: Add a note about CLEAR_ENV behaviour This seems like something to fix later, outside embargo. Signed-off-by: Simon McVittie --- portal/flatpak-portal.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/portal/flatpak-portal.c b/portal/flatpak-portal.c index 28ce22d5..41dbbfbb 100644 --- a/portal/flatpak-portal.c +++ b/portal/flatpak-portal.c @@ -990,6 +990,11 @@ handle_spawn (PortalFlatpak *object, fd_map[i].to = ++max_fd; } + /* TODO: Ideally we should let `flatpak run` inherit the portal's + * environment, in case e.g. a LD_LIBRARY_PATH is needed to be able + * to run `flatpak run`, but tell it to start from a blank environment + * when running the Flatpak app; but this isn't currently possible, so + * for now we preserve existing behaviour. */ if (arg_flags & FLATPAK_SPAWN_FLAGS_CLEAR_ENV) { char *empty[] = { NULL };