From 624cc6ff0b31bbd2f3ea6797ca87b1886922c0e8 Mon Sep 17 00:00:00 2001 From: Matthew Leeds Date: Sun, 2 Dec 2018 22:14:43 -0800 Subject: [PATCH] install: Don't search noenumerate remotes Currently if you don't specify a remote to the install command, it might suggest that you use an origin remote like "org.gnome.Builder-origin" which doesn't make much sense since those are tightly tied to the app installed via bundle that created them. So this commit respects the "xa.noenumerate" flag that is set on such remotes, so they aren't searched for refs. Closes: #2376 Approved by: matthiasclasen --- app/flatpak-builtins-install.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/flatpak-builtins-install.c b/app/flatpak-builtins-install.c index 8298a0c0..1001f105 100644 --- a/app/flatpak-builtins-install.c +++ b/app/flatpak-builtins-install.c @@ -347,7 +347,8 @@ flatpak_builtin_install (int argc, char **argv, GCancellable *cancellable, GErro g_auto(GStrv) refs = NULL; g_autoptr(GError) local_error = NULL; - if (flatpak_dir_get_remote_disabled (this_dir, this_remote)) + if (flatpak_dir_get_remote_disabled (this_dir, this_remote) || + flatpak_dir_get_remote_noenumerate (this_dir, this_remote)) continue; this_default_branch = flatpak_dir_get_remote_default_branch (this_dir, this_remote);