From 6d1d9724c5b30c680e5eefe05f5ddf7b15fdc92e Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Fri, 27 May 2016 00:05:55 -0400
Subject: [PATCH] builder: Warn about bad module names

Putting spaces or slashes in module names is a recipe for
cryptic error from one of the many constructed flatpak
commandlines. Better warn early on, as soon as we see such
a name.
---
 builder/builder-module.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/builder/builder-module.c b/builder/builder-module.c
index 8b0dad02b..fffcc8bb8 100644
--- a/builder/builder-module.c
+++ b/builder/builder-module.c
@@ -199,12 +199,16 @@ builder_module_set_property (GObject      *object,
 {
   BuilderModule *self = BUILDER_MODULE (object);
   gchar **tmp;
+  char *p;
 
   switch (prop_id)
     {
     case PROP_NAME:
       g_clear_pointer (&self->name, g_free);
       self->name = g_value_dup_string (value);
+      if ((p = strchr (self->name, ' ')) ||
+          (p = strchr (self->name, '/')))
+        g_printerr ("Module names like '%s' containing '%c' are problematic. Expect errors.\n", self->name, *p);
       break;
 
     case PROP_SUBDIR: