From a70b7a76282ca4e6a8ef797c20cb78a75f09ed24 Mon Sep 17 00:00:00 2001 From: Phaedrus Leeds Date: Fri, 7 Aug 2020 14:33:25 -0700 Subject: [PATCH] installation: Clarify that SDKs aren't considered used The docs claimed that SDK runtimes are considered used even if there is no app using them or runtime for which they are the SDK, but the implementation does not match that. We could change the implementation to always consider SDK runtimes used, but that would be problematic because some apps use an SDK as their runtime, and in that case the runtime would persist forever after the app is uninstalled, instead of eventually being garbage collected by the subsequent commits to this one. --- common/flatpak-installation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/flatpak-installation.c b/common/flatpak-installation.c index 3957d5f2..f18622fb 100644 --- a/common/flatpak-installation.c +++ b/common/flatpak-installation.c @@ -2924,8 +2924,8 @@ find_used_refs (FlatpakDir *dir, * * Lists the installed references that are not 'used'. * - * A reference is used if it is either an application, or an sdk, - * or the runtime of a used ref, or an extension of a used ref. + * A reference is used if it is either an application, + * or the runtime or sdk of a used ref, or an extension of a used ref. * Pinned runtimes are also considered used; see flatpak-pin(1) and * flatpak_installation_list_pinned_refs(). *