From d73ce0c508eaae6652c5d49c49fa9a0c70f120a7 Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Tue, 10 Sep 2019 15:55:13 +0200 Subject: [PATCH] Fix leak in flatpak_dir_find_remote_related_for_metadata This puts the checksum autoptr in the inner scope of the loop where it gets assigned to avoid leaking all but the last iteration value. --- common/flatpak-dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/flatpak-dir.c b/common/flatpak-dir.c index 9a35e3bb..92f5e0e7 100644 --- a/common/flatpak-dir.c +++ b/common/flatpak-dir.c @@ -13579,7 +13579,6 @@ flatpak_dir_find_remote_related_for_metadata (FlatpakDir *self, g_autofree char *extension_collection_id = NULL; const char *default_branches[] = { NULL, NULL}; const char **branches; - g_autofree char *checksum = NULL; int branch_i; /* Parse actual extension name */ @@ -13616,6 +13615,7 @@ flatpak_dir_find_remote_related_for_metadata (FlatpakDir *self, for (branch_i = 0; branches[branch_i] != NULL; branch_i++) { g_autofree char *extension_ref = NULL; + g_autofree char *checksum = NULL; const char *branch = branches[branch_i]; extension_ref = g_build_filename ("runtime", extension, parts[2], branch, NULL);