From dfe995a457098772f9c7caac4c83595c0e84f2c2 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 15 Feb 2024 01:20:02 +0000 Subject: [PATCH] testlibrary: Don't leak list of subpaths flatpak_deploy_data_get_subpaths() returns a new array (of unowned strings) and flatpak_dir_new_deploy_data() doesn't take ownership. Signed-off-by: Simon McVittie --- tests/testlibrary.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/testlibrary.c b/tests/testlibrary.c index 52b9b3ac..72986074 100644 --- a/tests/testlibrary.c +++ b/tests/testlibrary.c @@ -1992,6 +1992,7 @@ mangle_deploy_file (FlatpakInstalledRef *ref) GVariantBuilder metadata_builder; g_autoptr(GError) error = NULL; const char * const previous_ids[] = { "net.example.Goodbye", NULL }; + g_autofree const char **subpaths = NULL; dir = g_file_new_for_path (flatpak_installed_ref_get_deploy_dir (ref)); data = flatpak_load_deploy_data (dir); @@ -2002,9 +2003,10 @@ mangle_deploy_file (FlatpakInstalledRef *ref) g_variant_builder_add (&metadata_builder, "{s@v}", "previous-ids", g_variant_new_variant (g_variant_new_strv (previous_ids, -1))); + subpaths = flatpak_deploy_data_get_subpaths (data); new_data = flatpak_dir_new_deploy_data (flatpak_deploy_data_get_origin (data), flatpak_deploy_data_get_commit (data), - (char **) flatpak_deploy_data_get_subpaths (data), + (char **) subpaths, flatpak_deploy_data_get_installed_size (data), g_variant_builder_end (&metadata_builder));