From f035cbef489e87cd6ee091a952586b2d9bd5df91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dan=20Vr=C3=A1til?= Date: Wed, 6 May 2015 17:37:52 +0200 Subject: [PATCH] Don't clear the [Vars] group in build-finish command and improve error reporting --- xdg-app-builtins-build-finish.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xdg-app-builtins-build-finish.c b/xdg-app-builtins-build-finish.c index 3d6a6a0e..d0179b1b 100644 --- a/xdg-app-builtins-build-finish.c +++ b/xdg-app-builtins-build-finish.c @@ -317,8 +317,6 @@ update_metadata (GFile *base, GCancellable *cancellable, GError **error) } } - /* We don't care about error here (when the group does not exist for instance) */ - g_key_file_remove_group (keyfile, "Vars", NULL); if (opt_env_override) { for (i = 0; opt_env_override[i]; i++) @@ -328,6 +326,11 @@ update_metadata (GFile *base, GCancellable *cancellable, GError **error) { g_key_file_set_string (keyfile, "Vars", split[0], split[1] ? split[1] : ""); } + else + { + g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, "Cannot parse variable %s", opt_env_override[i]); + goto out; + } } }