From fa005cdbbfbb52561a02daab92906fb18eb5c6d4 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Mon, 12 Dec 2022 16:06:53 +0000 Subject: [PATCH] exports: Test that a symlink to the root directory is rejected Reproduces: https://github.com/flatpak/flatpak/issues/1357 Signed-off-by: Simon McVittie --- tests/test-exports.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/test-exports.c b/tests/test-exports.c index 235c515d..6be9567a 100644 --- a/tests/test-exports.c +++ b/tests/test-exports.c @@ -1360,6 +1360,7 @@ test_exports_unusual (void) { "home", FAKE_SYMLINK, "var/home" }, { "lib", FAKE_SYMLINK, "usr/lib" }, { "recursion", FAKE_SYMLINK, "recursion" }, + { "symlink-to-root", FAKE_SYMLINK, "." }, { "tmp", FAKE_SYMLINK, "TMP" }, { "usr/bin", FAKE_DIR }, { "usr/lib", FAKE_DIR }, @@ -1417,6 +1418,14 @@ test_exports_unusual (void) g_assert_false (ok); g_clear_error (&error); + ok = flatpak_exports_add_path_expose (exports, + FLATPAK_FILESYSTEM_MODE_READ_ONLY, + "/symlink-to-root", &error); + g_assert_error (error, G_IO_ERROR, G_IO_ERROR_NOT_MOUNTABLE_FILE); + g_test_message ("attempting to export /symlink-to-root: %s", error->message); + g_assert_false (ok); + g_clear_error (&error); + ok = flatpak_exports_add_path_expose (exports, FLATPAK_FILESYSTEM_MODE_READ_ONLY, "/tmp", &error);