From fd56fb85f81e901a7e33f2fa47e755bd7d989997 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 15 Feb 2024 00:08:41 +0000 Subject: [PATCH] populate_commit_data_cache: Don't leak child value g_variant_get_child_value() returns a non-floating reference, so g_variant_builder_add() will not sink it. Signed-off-by: Simon McVittie --- common/flatpak-utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/flatpak-utils.c b/common/flatpak-utils.c index 42353409..b9533f25 100644 --- a/common/flatpak-utils.c +++ b/common/flatpak-utils.c @@ -3301,7 +3301,8 @@ populate_commit_data_cache (OstreeRepo *repo, { VarVariantRef v = var_metadata_entry_get_value (m); GVariant *vv = var_variant_dup_to_gvariant (v); - g_variant_builder_add (&sparse_builder, "{sv}", m_key, g_variant_get_child_value (vv, 0)); + g_autoptr(GVariant) child = g_variant_get_child_value (vv, 0); + g_variant_builder_add (&sparse_builder, "{sv}", m_key, child); has_sparse = TRUE; } }