From ff2f18cb4241e915f9c7eac79fb20e4f7d30f6ca Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Sat, 26 Apr 2025 13:09:20 +0300 Subject: [PATCH] ci: Do not build with ASAN on older ubuntu We already build and test with asan with the newer toolchain in the ubuntu 24.04 job. Sometimes the older toolchain found in 22.04 or the asan version will trigger issues that are either false positive or that have been already against in newer versions. --- .github/workflows/check.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 9537da67..3d94fb8b 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -124,11 +124,11 @@ jobs: - name: Create logs dir run: mkdir test-logs - name: configure - # We don't do gtk-doc or GObject-Introspection here, because they can - # clash with AddressSanitizer. Instead, the clang build enables those. + # Sometimes the older sanitizer toolchains will trigger issues that are either + # false positive or that have been already against in newer versions, so we don't + # enable them here. run: | meson setup \ - -Db_sanitize=address,undefined \ -Dgir=disabled \ -Dgtkdoc=disabled \ -Dhttp_backend=soup \ @@ -142,7 +142,6 @@ jobs: - name: Run tests run: meson test -C _build env: - ASAN_OPTIONS: detect_leaks=0 # Right now we're not fully clean, but this gets us use-after-free etc LC_ALL: en_US.UTF-8 - name: Collect overall test logs on failure if: failure()