mirror of
https://github.com/flatpak/flatpak.git
synced 2026-03-26 02:45:15 -04:00
c0ad159e4a
First of all, g_strcmp0() is NULL-safe, so there's no need to check if
ref_str is NULL or not.
Secondly, the NULL check triggers Coverity. It thinks that ref_str
might be NULL in the 'else' branch, where ref_str is unconditionally
accessed by flatpak_decomposed_new_from_ref(). There's no need to be
concerned about this because ref_str can't be NULL. It's one of the
parameters of the o.fd.Flatpak.SystemHelper.Deploy D-Bus method. It's
defined as an 's', and NULL is not a valid value for 's'. In fact,
this D-Bus argument is assumed to be not NULL when the Deploy method is
handled.
Fallout from 701602c6ca