Simon McVittie 8deef94f9d icon-validator: Remove remnants of GSpawn error handling ...

Now that validate-icon uses execvpe(), status and error were never set,
so rerun_in_sandbox() would have crashed while dereferencing a NULL
error if execvpe() failed. This is reproducible with, for example:

    FLATPAK_BWRAP=/bin/nope flatpak-validate-icon --sandbox 48 48 /path/to/icon

execvpe() does not return on success (the process image is replaced),
and sets errno on failure, so behave accordingly.

Also print the error message to stderr, even if G_MESSAGES_DEBUG is not
set, since it's our only opportunity to indicate to a caller what has
gone wrong.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Closes: #2950
Approved by: alexlarsson

2019-06-12 06:51:53 +00:00

..

Makefile.am.inc

Make the icon validator sandbox itself

2019-01-21 09:17:29 +00:00

validate-icon.c

icon-validator: Remove remnants of GSpawn error handling

2019-06-12 06:51:53 +00:00