mirror of
https://github.com/flatpak/flatpak.git
synced 2026-02-02 12:01:32 -05:00
5813639f15
In list_remotes_for_configured_remote(), we call ostree_repo_finder_avahi_start() without checking the error status. This means the OstreeRepoFinderAvahi instance passed to ostree_repo_find_remotes_async() could be in an error state, which leads to flatpak getting infinitely stuck waiting for the result of that operation. So this commit removes the OstreeRepoFinderAvahi instance from the array if it failed to start, and returns early if only LAN remotes were requested. This is also consistent with how ostree itself handles an error starting the Avahi finder instance in case NULL is passed to ostree_repo_find_remotes_async() instead of a finders array. This error condition happens on the Endless OBS server because there's no Avahi daemon in the chroot used to run "make check". Closes: #1587 Approved by: mwleeds