mirror of
https://github.com/flatpak/flatpak.git
synced 2026-03-14 05:02:44 -04:00
1d7357616b
In extract_extra_data(), flatpak currently returns TRUE whenever flatpak_repo_get_extra_data_sources() returns NULL, which is correct most of the times since that's usually caused by the extra-data finish-args argument not being present. However, that operation relies on OSTree's ostree_repo_load_variant() too, which could fail for unrelated reasons. And in those cases flatpak would still keep returning TRUE here even in cases where the extra-data sources could be there, but an error happened while retrieving it. This seems to be a bug leading to unlikely -yet possible- situations, where the user would end up with an "external app" like Spotify reported to be succesfully installed but without the files/extra directory, which is useless.