Matthew Leeds 19b5033942 build-bundle: Fix resolving refs ...

Unfortunately in commit 253fcc6e3 I broke the build-bundle command so
that it is unable to resolve remote refs (as opposed to local ones).
This means in the normal case of building a bundle for an app installed
from a remote it fails:

$ flatpak build-bundle /var/lib/flatpak/repo gnome-calculator.flatpak org.gnome.Calculator stable
error: Refspec 'app/org.gnome.Calculator/x86_64/stable' not found

This is because flatpak_repo_resolve_rev() interprets a NULL remote name
to mean the ref is local (in refs/heads/) but in this case we just don't
know which remote it's from. This commit fixes the issue by using
ostree_repo_resolve_rev() directly which searches refs/heads/ and
refs/remotes/, and if that fails falling back to iterating over refs
returned by ostree_repo_list_collection_refs() to catch collection-refs
that may be in refs/mirrors/.

Also, add a unit test that fails without this patch.

Fixes https://github.com/flatpak/flatpak/issues/3026

Closes: #3032
Approved by: alexlarsson

(cherry picked from commit 5e65174e8d)

2019-09-18 19:21:47 +02:00

..

test-keyring

Add make-test-bundles.sh

2016-02-25 15:27:37 +01:00

test-keyring2

tests: Add a second gpg keyring

2017-05-10 11:54:27 +02:00

expand-test-matrix.sh

Fix misspellings

2019-04-08 12:50:42 +00:00

flatpak.supp

tests: Add gnutls valgrind suppression

2019-04-12 13:01:08 +02:00

glib.supp

Update valgrind suppressions

2019-01-15 16:02:34 +01:00

http-utils-test-server.py

Make test scripts bilingual Python 2/Python 3

2018-08-27 10:36:28 +00:00

httpcache.c

Fix a leak of SoupSession

2019-03-06 23:44:50 +00:00

libtest.sh

Fix installable tests when running on a tty

2019-05-16 15:24:47 +00:00

make-multi-collection-id-repo.sh

tests: Add ability to test a branch other than master

2019-03-30 13:02:10 +00:00

make-test-app.sh

tests: Consistently use a bash shebang

2019-05-09 09:12:26 +00:00

make-test-runtime.sh

tests: Consistently use a bash shebang

2019-05-09 09:12:26 +00:00

Makefile-test-matrix.am.inc

tests: Add test-p2p-security.sh

2019-05-09 09:12:26 +00:00

Makefile.am.inc

tests: Add test-p2p-security.sh

2019-05-09 09:12:26 +00:00

oci-registry-client.py

Make test scripts bilingual Python 2/Python 3

2018-08-27 10:36:28 +00:00

oci-registry-server.py

tests/oci-registry-server.py: Delete old images for the tag when creating

2019-05-09 12:22:44 +00:00

org.test.Hello.png

Add appdata to test apps

2016-02-25 19:03:09 +01:00

session.conf.in

Add some missing files from the tests

2016-05-02 10:46:51 +02:00

test-basic.sh

Update tests

2019-01-11 19:19:54 -05:00

test-build-update-repo.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-bundle.sh

build-bundle: Fix resolving refs

2019-09-18 19:21:47 +02:00

test-completion.sh

list/remote-ls/search: Split description field

2019-04-24 13:31:35 +00:00

test-config.sh

Add some tests for flatpak config

2019-01-11 12:40:36 +00:00

test-default-remotes.sh

Support .flatpakrepo files in /etc/flatpak/remotes.d

2019-05-08 08:13:52 +00:00

test-extensions.sh

run: Try to determine the branch if unspecified

2019-03-30 13:02:10 +00:00

test-http-utils.sh

tests: Run in /tmp

2018-10-03 13:19:35 +00:00

test-info.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-oci-registry.sh

tests: Add test for updating from oci remote (currently broken)

2019-05-09 12:22:44 +00:00

test-oci.sh

tests: Escape periods when appropriate

2019-04-05 14:23:07 +00:00

test-override.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-p2p-security.sh

tests: Add test-p2p-security.sh

2019-05-09 09:12:26 +00:00

test-repo.sh

fix distcheck: Pass -f to rm to avoid interactive prompt

2019-05-10 09:07:41 +02:00

test-run.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-unsigned-summaries.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-update-remote-configuration.sh

Skip some tests if we can't use FUSE

2019-04-15 03:09:00 +00:00

test-webserver.sh

test-webserver: Fix race condition

2018-09-24 08:06:51 +00:00

test-wrapper.sh

tests: Add system-norevokefs alternative to check fallback paths

2019-04-09 09:18:15 +00:00

test.filter

tests: Add tests for client-side filtering

2019-05-06 13:58:58 +00:00

testcommon.c

Fix installable tests when running on a tty

2019-05-16 15:24:47 +00:00

testlibrary.c

lib Add flatpak_remote_new_from_file() to add remotes from flatpakrefs

2019-05-09 12:39:36 +00:00