Matthew Leeds 5e65174e8d build-bundle: Fix resolving refs ...

Unfortunately in commit 253fcc6e3 I broke the build-bundle command so
that it is unable to resolve remote refs (as opposed to local ones).
This means in the normal case of building a bundle for an app installed
from a remote it fails:

$ flatpak build-bundle /var/lib/flatpak/repo gnome-calculator.flatpak org.gnome.Calculator stable
error: Refspec 'app/org.gnome.Calculator/x86_64/stable' not found

This is because flatpak_repo_resolve_rev() interprets a NULL remote name
to mean the ref is local (in refs/heads/) but in this case we just don't
know which remote it's from. This commit fixes the issue by using
ostree_repo_resolve_rev() directly which searches refs/heads/ and
refs/remotes/, and if that fails falling back to iterating over refs
returned by ostree_repo_list_collection_refs() to catch collection-refs
that may be in refs/mirrors/.

Also, add a unit test that fails without this patch.

Fixes https://github.com/flatpak/flatpak/issues/3026

Closes: #3032
Approved by: alexlarsson

2019-08-15 19:42:45 +00:00

..

flatpak-builtins-build-bundle.c

build-bundle: Fix resolving refs

2019-08-15 19:42:45 +00:00

flatpak-builtins-build-commit-from.c

app/flatpak-builtins-build-commit-from.c: Recalculate download-size metadata

2019-05-28 12:46:13 +00:00

flatpak-builtins-build-export.c

Made wider use of flatpak_repo_resolve_rev()

2019-05-09 09:12:26 +00:00

flatpak-builtins-build-finish.c

Remove extra newlines in variable definiton blocks

2019-02-25 18:12:30 +00:00

flatpak-builtins-build-import-bundle.c

Remove extra newlines in variable definiton blocks

2019-02-25 18:12:30 +00:00

flatpak-builtins-build-init.c

build-init: Export an extension's runtime in the metadata

2019-06-12 06:23:07 +00:00

flatpak-builtins-build-sign.c

Made wider use of flatpak_repo_resolve_rev()

2019-05-09 09:12:26 +00:00

flatpak-builtins-build-update-repo.c

build-update-repo: Support setting comment/description/homepage/icon

2019-04-10 14:34:32 +00:00

flatpak-builtins-build.c

run: Support migration from old app-ids to new app-id

2019-04-12 08:59:35 +00:00

flatpak-builtins-config.c

config: Make --list and --get work on empty repos

2019-01-14 11:10:17 +00:00

flatpak-builtins-create-usb.c

create-usb: Delete local repo summary if it exists

2019-04-24 13:28:21 +00:00

flatpak-builtins-document-export.c

common: Rename all generated files to *-dbus-generated.[ch]

2018-05-24 11:59:52 +00:00

flatpak-builtins-document-info.c

common: Rename all generated files to *-dbus-generated.[ch]

2018-05-24 11:59:52 +00:00

flatpak-builtins-document-list.c

CLI: Add skip_unique_if_default to Column

2019-04-23 13:05:14 +00:00

flatpak-builtins-document-unexport.c

common: Rename all generated files to *-dbus-generated.[ch]

2018-05-24 11:59:52 +00:00

flatpak-builtins-enter.c

app, common: Use glnx_readlinkat_malloc()

2019-05-01 16:39:18 +00:00

flatpak-builtins-history.c

CLI: Add skip_unique_if_default to Column

2019-04-23 13:05:14 +00:00

flatpak-builtins-info.c

Run uncrustify

2019-02-25 18:12:30 +00:00

flatpak-builtins-install.c

app: Don't show arch column if it's not interesting

2019-05-30 12:12:12 +00:00

flatpak-builtins-kill.c

Run uncrustify

2019-02-25 18:12:30 +00:00

flatpak-builtins-list.c

list/remote-ls/search: Split description field

2019-04-24 13:31:35 +00:00

flatpak-builtins-make-current.c

make-current: Don't fail completion on empty repos

2019-01-14 11:10:17 +00:00

flatpak-builtins-override.c

Remove extra newlines near curly braces

2019-02-25 18:12:30 +00:00

flatpak-builtins-permission-list.c

Fix a thinko in the permission commands

2018-09-25 12:17:16 +00:00

flatpak-builtins-permission-remove.c

Fix a thinko in the permission commands

2018-09-25 12:17:16 +00:00

flatpak-builtins-permission-reset.c

permission-reset: Add an --all option

2019-04-23 07:54:06 +00:00

flatpak-builtins-permission-show.c

Fix a thinko in the permission commands

2018-09-25 12:17:16 +00:00

flatpak-builtins-ps.c

CLI: Add skip_unique_if_default to Column

2019-04-23 13:05:14 +00:00

flatpak-builtins-remote-add.c

remote-add: Don't fail if metadata updates fail, just warn

2019-05-08 08:13:52 +00:00

flatpak-builtins-remote-delete.c

remote-delete: Manually delete origin remotes if no refs were removed

2019-06-12 07:07:30 +00:00

flatpak-builtins-remote-info.c

Add FLATPAK_ERROR_REF_NOT_FOUND

2019-05-13 10:57:11 +00:00

flatpak-builtins-remote-list.c

flatpak remotes - show filter in list

2019-05-06 13:58:58 +00:00

flatpak-builtins-remote-ls.c

remote-ls: Add --cached option

2019-04-26 08:00:27 +00:00

flatpak-builtins-remote-modify.c

flatpak remote-modify add --filter and --no-filter options

2019-05-06 13:58:58 +00:00

flatpak-builtins-repair.c

Remove extra newlines in variable definiton blocks

2019-02-25 18:12:30 +00:00

flatpak-builtins-repo.c

Made wider use of flatpak_repo_resolve_rev()

2019-05-09 09:12:26 +00:00

flatpak-builtins-run.c

run: Try to determine the branch if unspecified

2019-03-30 13:02:10 +00:00

flatpak-builtins-search.c

list/remote-ls/search: Split description field

2019-04-24 13:31:35 +00:00

flatpak-builtins-uninstall.c

app: Don't show arch column if it's not interesting

2019-05-30 12:12:12 +00:00

flatpak-builtins-update.c

app: Don't show arch column if it's not interesting

2019-05-30 12:12:12 +00:00

flatpak-builtins-utils.c

remote-info: Add --cached support

2019-04-26 08:00:27 +00:00

flatpak-builtins-utils.h

remote-info: Add --cached support

2019-04-26 08:00:27 +00:00

flatpak-builtins.h

Fix misspellings

2019-04-08 12:50:42 +00:00

flatpak-cli-transaction.c

cli-transaction: Fix some leaks

2019-07-23 14:54:59 +00:00

flatpak-cli-transaction.h

app: Don't show arch column if it's not interesting

2019-05-30 12:12:12 +00:00

flatpak-complete.c

Remove extra newlines in variable definiton blocks

2019-02-25 18:12:30 +00:00

flatpak-complete.h

completion: Add an api to complete columns

2019-01-11 14:00:59 +00:00

flatpak-main.c

Don't register polkit agent if we cannot connect to system bus

2019-07-11 18:11:21 +00:00

flatpak-polkit-agent-text-listener.c

polkit: Ignore deprecations

2019-01-11 22:34:24 +00:00

flatpak-polkit-agent-text-listener.h

Add our own polkit listener implementation

2018-12-06 15:01:14 +00:00

flatpak-quiet-transaction.c

cli: Drop unnecessary "something failed" message with --noninteractive

2019-04-25 10:01:14 +00:00

flatpak-quiet-transaction.h

Run uncrustify

2019-02-25 18:12:30 +00:00

flatpak-table-printer.c

app: Avoid a potential segfault when skipping columns

2019-06-07 03:48:33 +00:00

flatpak-table-printer.h

CLI: Add skip_unique_if_default to Column

2019-04-23 13:05:14 +00:00

Makefile.am.inc

build-export: Use the icon validator

2019-01-17 07:27:31 +00:00

parse-datetime.h

Run uncrustify

2018-07-08 10:05:37 +00:00

parse-datetime.y

Import parse_timestamp() from ostree

2018-04-04 15:08:49 +00:00