mirror of
https://github.com/flatpak/flatpak.git
synced 2026-03-19 15:37:11 -04:00
013263fcc0
Currently when you try to do an offline app install from a USB drive, the install succeeds but without installing any of the related refs, even if they're available on the USB. This means you end up with a broken install that's missing locale extensions, content, etc. depending on what the related refs provide. The related ref information is already gleaned from the xa.cache data which is available offline via ostree-metadata refs that should be provided by peer sources (and available in summary files as well). In the near future this will be changed so that we use commit metadata instead of xa.cache (see https://github.com/flatpak/flatpak/issues/1592) but for now it at least allows offline installs to work. So the only remaining step is to remove a dependency on the remote summary when checking for the related ref in the remote in flatpak_dir_find_remote_related(). This is accomplished by reworking flatpak_remote_state_lookup_ref() so that it falls back to using the xa.cache data when the summary isn't available. One effect of this is that we no longer necessarily have the checksum for the ref, since checksums aren't present in xa.cache data. As far as I can tell, none of the consumers of this API have a hard dependency on the checksum information (I checked GNOME Software too). This is a partial fix for https://github.com/flatpak/flatpak/issues/1583 Closes: #1673 Approved by: pwithnall