From 630d878a3c7c065bd592d52a404851df716f6800 Mon Sep 17 00:00:00 2001 From: Romuald Juchnowicz-Bierbasz Date: Fri, 12 Jul 2019 11:46:24 +0200 Subject: [PATCH] Use constants --- src/galaxy/http.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/galaxy/http.py b/src/galaxy/http.py index 65cfd22..1e6db79 100644 --- a/src/galaxy/http.py +++ b/src/galaxy/http.py @@ -13,9 +13,13 @@ from galaxy.api.errors import ( ) +DEFAULT_LIMIT = 20 +DEFAULT_TIMEOUT = 60 # seconds + + class HttpClient: """Deprecated""" - def __init__(self, limit=20, timeout=aiohttp.ClientTimeout(total=60), cookie_jar=None): + def __init__(self, limit=DEFAULT_LIMIT, timeout=aiohttp.ClientTimeout(total=DEFAULT_TIMEOUT), cookie_jar=None): connector = create_tcp_connector(limit=limit) self._session = create_client_session(connector=connector, timeout=timeout, cookie_jar=cookie_jar) @@ -31,13 +35,13 @@ def create_tcp_connector(*args, **kwargs): ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT) ssl_context.load_verify_locations(certifi.where()) kwargs.setdefault("ssl", ssl_context) - kwargs.setdefault("limit", 20) + kwargs.setdefault("limit", DEFAULT_LIMIT) return aiohttp.TCPConnector(*args, **kwargs) def create_client_session(*args, **kwargs): kwargs.setdefault("connector", create_tcp_connector()) - kwargs.setdefault("timeout", aiohttp.ClientTimeout(total=60)) + kwargs.setdefault("timeout", aiohttp.ClientTimeout(total=DEFAULT_TIMEOUT)) kwargs.setdefault("raise_for_status", True) return aiohttp.ClientSession(*args, **kwargs)