From 8f91f705ee33ba6318da2d4017cf4dd2f4d6d9ac Mon Sep 17 00:00:00 2001 From: Miron Moderau Date: Wed, 8 Sep 2021 11:33:16 +0200 Subject: [PATCH] Remove LoggedInElsewhere error type This error is obsolete. It was never used by most plugins and Galaxy does not handle it in any specific way. --- src/galaxy/api/errors.py | 4 ---- tests/test_authenticate.py | 13 ++++++++++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/galaxy/api/errors.py b/src/galaxy/api/errors.py index d5424bc..a66a206 100644 --- a/src/galaxy/api/errors.py +++ b/src/galaxy/api/errors.py @@ -34,10 +34,6 @@ class NetworkError(ApplicationError): def __init__(self, data=None): super().__init__(101, "Network error", data) -class LoggedInElsewhere(ApplicationError): - def __init__(self, data=None): - super().__init__(102, "Logged in elsewhere", data) - class ProtocolError(ApplicationError): def __init__(self, data=None): super().__init__(103, "Protocol error", data) diff --git a/tests/test_authenticate.py b/tests/test_authenticate.py index 9bbb6e8..931c246 100644 --- a/tests/test_authenticate.py +++ b/tests/test_authenticate.py @@ -2,8 +2,16 @@ import pytest from galaxy.api.types import Authentication from galaxy.api.errors import ( - UnknownError, InvalidCredentials, NetworkError, LoggedInElsewhere, ProtocolError, - BackendNotAvailable, BackendTimeout, BackendError, TemporaryBlocked, Banned, AccessDenied + UnknownError, + BackendNotAvailable, + BackendTimeout, + BackendError, + InvalidCredentials, + NetworkError, + ProtocolError, + TemporaryBlocked, + Banned, + AccessDenied, ) from galaxy.unittest.mock import async_return_value, skip_loop @@ -42,7 +50,6 @@ async def test_success(plugin, read, write): pytest.param(BackendError, 4, "Backend error", id="backend_error"), pytest.param(InvalidCredentials, 100, "Invalid credentials", id="invalid_credentials"), pytest.param(NetworkError, 101, "Network error", id="network_error"), - pytest.param(LoggedInElsewhere, 102, "Logged in elsewhere", id="logged_elsewhere"), pytest.param(ProtocolError, 103, "Protocol error", id="protocol_error"), pytest.param(TemporaryBlocked, 104, "Temporary blocked", id="temporary_blocked"), pytest.param(Banned, 105, "Banned", id="banned"),