mirror of
https://github.com/nicolargo/glances.git
synced 2026-09-15 14:50:17 -04:00
Sanjay Santhanam
2bc099d820
get_default_ret_value() collapsed every matching condition into a single 'ret' key, so the level that won was whichever condition was evaluated last rather than the most severe one. A URL that was both failing and slow was reported as WARNING instead of CRITICAL, and a URL whose first scan had not completed matched both CAREFUL and CRITICAL and was shown as CRITICAL (which could also fire ports_critical_action). Resolve by severity (CRITICAL > WARNING > CAREFUL > OK) and stop a None status from matching the CRITICAL condition for web checks. Adds tests/test_plugin_ports.py covering the severity ordering and the four web scan outcomes. Closes #3632
68 lines
2.6 KiB
Python
68 lines
2.6 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# Glances - An eye on your system
|
|
#
|
|
# SPDX-FileCopyrightText: 2026 Nicolas Hennion <nicolas@nicolargo.com>
|
|
#
|
|
# SPDX-License-Identifier: LGPL-3.0-only
|
|
#
|
|
|
|
"""Tests for the Ports plugin."""
|
|
|
|
import pytest
|
|
|
|
from glances.plugins.ports import PortsPlugin
|
|
|
|
|
|
@pytest.fixture
|
|
def ports_plugin():
|
|
"""Return a Ports plugin instance without running its full init."""
|
|
return PortsPlugin.__new__(PortsPlugin)
|
|
|
|
|
|
def web_scan(status, elapsed=0, rtt_warning=1):
|
|
"""Return a web scan result as stored by the ports plugin."""
|
|
return {'status': status, 'elapsed': elapsed, 'rtt_warning': rtt_warning}
|
|
|
|
|
|
class TestPortsPluginAlertLevel:
|
|
"""Test that the alert level is resolved by severity, not by dict ordering."""
|
|
|
|
@pytest.mark.parametrize(
|
|
('conds', 'expected'),
|
|
[
|
|
({'CAREFUL': True, 'CRITICAL': True, 'WARNING': True}, 'CRITICAL'),
|
|
({'CAREFUL': True, 'CRITICAL': False, 'WARNING': True}, 'WARNING'),
|
|
({'CAREFUL': True, 'CRITICAL': False, 'WARNING': False}, 'CAREFUL'),
|
|
({'CAREFUL': False, 'CRITICAL': False, 'WARNING': False}, 'OK'),
|
|
],
|
|
)
|
|
def test_most_severe_condition_wins(self, ports_plugin, conds, expected):
|
|
"""Test that the most severe matching condition is returned."""
|
|
assert ports_plugin.get_default_ret_value(conds) == expected
|
|
|
|
def test_web_not_scanned_yet_is_careful(self, ports_plugin):
|
|
"""Test that a URL whose first scan did not complete is not CRITICAL."""
|
|
conds = ports_plugin.get_conds_if_url(web_scan(None))
|
|
assert ports_plugin.get_default_ret_value(conds) == 'CAREFUL'
|
|
|
|
def test_web_failing_and_slow_is_critical(self, ports_plugin):
|
|
"""Test that a failing URL stays CRITICAL even when it is also slow."""
|
|
conds = ports_plugin.get_conds_if_url(web_scan(404, elapsed=5))
|
|
assert ports_plugin.get_default_ret_value(conds) == 'CRITICAL'
|
|
|
|
def test_web_failing_and_fast_is_critical(self, ports_plugin):
|
|
"""Test that a failing URL is CRITICAL."""
|
|
conds = ports_plugin.get_conds_if_url(web_scan(404))
|
|
assert ports_plugin.get_default_ret_value(conds) == 'CRITICAL'
|
|
|
|
def test_web_ok_but_slow_is_warning(self, ports_plugin):
|
|
"""Test that a reachable but slow URL is WARNING."""
|
|
conds = ports_plugin.get_conds_if_url(web_scan(200, elapsed=5))
|
|
assert ports_plugin.get_default_ret_value(conds) == 'WARNING'
|
|
|
|
def test_web_ok_and_fast_is_ok(self, ports_plugin):
|
|
"""Test that a reachable and fast URL is OK."""
|
|
conds = ports_plugin.get_conds_if_url(web_scan(200))
|
|
assert ports_plugin.get_default_ret_value(conds) == 'OK'
|