mirror of
https://github.com/nicolargo/glances.git
synced 2026-06-03 03:15:09 -04:00
33a90f5eb8
Step 1 of the mode-dispatch refactor (plan ``docs/superpowers/plans/2026-05-15-glances-v5-phase2-g2.md``). This commit only introduces the flags + cross-flag validation; the dispatch wiring lands in Tasks 2 and 3. - ``-s`` / ``--server``: opt in to the REST API mode (headless). - ``--enable-mcp``: mount /mcp; requires ``--server`` — caught by ``validate_args`` with a clear stderr message + argparse exit 2. - ``--quiet`` / ``--no-tui``: kept (open point — see plan G2 §"Open points"). When passed together with ``-s`` an info log notes that the flag is redundant. - New ``validate_args`` helper called from ``main()`` after ``setup_logging``. 15 new tests in ``tests/test_cli_v5.py`` covering parser shape, defaults, alias spellings, and the validation rules.
128 lines
3.9 KiB
Python
128 lines
3.9 KiB
Python
"""Glances v5 — argparse-level tests for the CLI (main_v5.build_parser).
|
|
|
|
Covers the new G2 dispatch flags:
|
|
- ``-s`` / ``--server`` — opt in to REST API mode (headless).
|
|
- ``--enable-mcp`` — mount the MCP endpoint; requires ``--server``.
|
|
|
|
Plus the legacy ``--quiet`` / ``--no-tui`` flag is still accepted
|
|
(deprecation note in a follow-up phase — see plan G2 Task 1 Step 3 and
|
|
the "Open points" section).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
|
|
import pytest
|
|
|
|
from glances.main_v5 import build_parser, validate_args
|
|
|
|
# ---------------------------------------------------------------- parser
|
|
|
|
|
|
def test_parser_accepts_short_server_flag():
|
|
args = build_parser().parse_args(["-s"])
|
|
assert args.server is True
|
|
|
|
|
|
def test_parser_accepts_long_server_flag():
|
|
args = build_parser().parse_args(["--server"])
|
|
assert args.server is True
|
|
|
|
|
|
def test_parser_default_server_is_false():
|
|
args = build_parser().parse_args([])
|
|
assert args.server is False
|
|
|
|
|
|
def test_parser_accepts_enable_mcp_flag():
|
|
args = build_parser().parse_args(["-s", "--enable-mcp"])
|
|
assert args.enable_mcp is True
|
|
|
|
|
|
def test_parser_default_enable_mcp_is_false():
|
|
args = build_parser().parse_args([])
|
|
assert args.enable_mcp is False
|
|
|
|
|
|
def test_parser_quiet_and_no_tui_are_aliases():
|
|
"""The legacy flag has two spellings — both set ``args.no_tui``."""
|
|
args_quiet = build_parser().parse_args(["--quiet"])
|
|
args_no_tui = build_parser().parse_args(["--no-tui"])
|
|
assert args_quiet.no_tui is True
|
|
assert args_no_tui.no_tui is True
|
|
|
|
|
|
def test_parser_default_no_tui_is_false():
|
|
args = build_parser().parse_args([])
|
|
assert args.no_tui is False
|
|
|
|
|
|
def test_parser_keeps_existing_flags_working():
|
|
"""Sanity: pre-G2 flags still parse."""
|
|
args = build_parser().parse_args(["-C", "/tmp/glances.conf", "--bind", "0.0.0.0", "--port", "8080", "-d"])
|
|
assert args.config_path == "/tmp/glances.conf"
|
|
assert args.bind == "0.0.0.0"
|
|
assert args.port == 8080
|
|
assert args.debug is True
|
|
|
|
|
|
# ---------------------------------------------------------------- validation
|
|
|
|
|
|
def test_validate_rejects_mcp_without_server(capsys):
|
|
"""``--enable-mcp`` requires ``--server`` — error + exit."""
|
|
args = build_parser().parse_args(["--enable-mcp"])
|
|
with pytest.raises(SystemExit) as exc:
|
|
validate_args(args)
|
|
# argparse's parser.error() exits with code 2.
|
|
assert exc.value.code == 2
|
|
err = capsys.readouterr().err
|
|
assert "--enable-mcp" in err
|
|
assert "--server" in err
|
|
|
|
|
|
def test_validate_accepts_server_alone(capsys):
|
|
args = build_parser().parse_args(["-s"])
|
|
# Must not raise.
|
|
validate_args(args)
|
|
# No error output.
|
|
assert capsys.readouterr().err == ""
|
|
|
|
|
|
def test_validate_accepts_server_with_mcp(capsys):
|
|
args = build_parser().parse_args(["-s", "--enable-mcp"])
|
|
validate_args(args)
|
|
assert capsys.readouterr().err == ""
|
|
|
|
|
|
def test_validate_accepts_default_mode(capsys):
|
|
args = build_parser().parse_args([])
|
|
validate_args(args)
|
|
assert capsys.readouterr().err == ""
|
|
|
|
|
|
def test_validate_accepts_quiet_alone(capsys):
|
|
"""Legacy --quiet without -s is still accepted (deprecation later)."""
|
|
args = build_parser().parse_args(["--quiet"])
|
|
validate_args(args)
|
|
assert capsys.readouterr().err == ""
|
|
|
|
|
|
def test_validate_accepts_server_with_quiet(capsys, caplog):
|
|
"""``-s --quiet`` is harmless — -s already implies headless. Log a hint."""
|
|
args = build_parser().parse_args(["-s", "--quiet"])
|
|
with caplog.at_level("INFO"):
|
|
validate_args(args)
|
|
assert capsys.readouterr().err == ""
|
|
# A hint mentioning that -s already implies headless is logged.
|
|
joined = " ".join(rec.getMessage() for rec in caplog.records)
|
|
assert "--server" in joined or "-s" in joined
|
|
|
|
|
|
# ---------------------------------------------------------------- shape
|
|
|
|
|
|
def test_parser_is_argument_parser():
|
|
assert isinstance(build_parser(), argparse.ArgumentParser)
|