Merge pull request #761 from CjayBillones/refactor-spec-support

Refactor spec/support

spec/support/controller_macros.rb

@@ -1,9 +1,11 @@
 # Taken unashamedly from https://github.com/plataformatec/devise/wiki/How-To%3a-Controllers-and-Views-tests-with-Rails-3-%28and-rspec%29
 module ControllerMacros
   def login_member(member_factory=:member)
+    
+  	let(:member) { member = FactoryGirl.create(member_factory || :member) }
+
     before(:each) do
       @request.env["devise.mapping"] = Devise.mappings[:member]
-      member = FactoryGirl.create(member_factory || :member)
       sign_in member
     end
   end

spec/support/elasticsearch_helpers.rb

@@ -10,7 +10,7 @@ end
 RSpec.configure do |config|
   config.include ElasticsearchHelpers
 
-  config.before(:each) do
+  config.before(:all) do
     if ENV['GROWSTUFF_ELASTICSEARCH'] == "true"
       Crop.__elasticsearch__.create_index! force: true
     end