diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e700df88e..0634bd83e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -672,12 +672,6 @@ Rails/WhereEquals: - 'app/models/harvest.rb' - 'app/models/planting.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Rails/WhereMissing: - Exclude: - - 'app/controllers/crops_controller.rb' - # Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/WhereRange: diff --git a/app/controllers/crops_controller.rb b/app/controllers/crops_controller.rb index 9b71cf041..f9a0e2079 100644 --- a/app/controllers/crops_controller.rb +++ b/app/controllers/crops_controller.rb @@ -160,7 +160,7 @@ class CropsController < ApplicationController when 'youtube' Crop.approved.where(en_youtube_url: [nil, '']).order(plantings_count: :desc) when 'alternate_names' - Crop.approved.left_joins(:alternate_names).where(alternate_names: { id: nil }).order(plantings_count: :desc) + Crop.approved.where.missing(:alternate_names).order(plantings_count: :desc) when 'wikidata' crops_with_wikidata = Crop.joins(:scientific_names).where.not(scientific_names: { wikidata_id: nil }).distinct Crop.approved.where.not(id: crops_with_wikidata).order(plantings_count: :desc)