From 208b73c31eb76107006ec99bc5b7d56cf6218fe1 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Mon, 27 Apr 2026 01:14:11 +0930 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daniel O'Connor --- app/models/concerns/search_activities.rb | 2 +- app/models/concerns/search_plantings.rb | 2 +- app/models/concerns/search_seeds.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/concerns/search_activities.rb b/app/models/concerns/search_activities.rb index 4f13bb00f..bb87e5427 100644 --- a/app/models/concerns/search_activities.rb +++ b/app/models/concerns/search_activities.rb @@ -15,7 +15,7 @@ module SearchActivities } } - scope :search_import, -> { where("finished <> true OR updated_at >= ?", 2.years.ago) } + scope :search_import, -> { where("finished <> true OR activities.updated_at >= ?", 2.years.ago) } def should_index? !finished || updated_at >= 2.years.ago diff --git a/app/models/concerns/search_plantings.rb b/app/models/concerns/search_plantings.rb index 312cedce7..d525d8799 100644 --- a/app/models/concerns/search_plantings.rb +++ b/app/models/concerns/search_plantings.rb @@ -16,7 +16,7 @@ module SearchPlantings } } - scope :search_import, -> { where("NOT (finished = true OR failed = true) OR updated_at >= ?", 2.years.ago) } + scope :search_import, -> { where("NOT (finished = true OR failed = true) OR plantings.updated_at >= ?", 2.years.ago) } def should_index? (!finished && !failed) || updated_at >= 2.years.ago diff --git a/app/models/concerns/search_seeds.rb b/app/models/concerns/search_seeds.rb index dbad53477..3f259555a 100644 --- a/app/models/concerns/search_seeds.rb +++ b/app/models/concerns/search_seeds.rb @@ -16,7 +16,7 @@ module SearchSeeds } } - scope :search_import, -> { where("finished <> true OR updated_at >= ?", 2.years.ago) } + scope :search_import, -> { where("finished <> true OR seeds.updated_at >= ?", 2.years.ago) } def should_index? !finished || updated_at >= 2.years.ago