From 4bd322d8cacdde9f2deeddb811ceeb9d336ec107 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Sun, 10 Aug 2025 02:55:34 +0000 Subject: [PATCH 1/5] Target a desktop --- spec/rails_helper.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 3c17087a9..b85f2e627 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -22,6 +22,7 @@ Capybara.register_driver :selenium_chrome_customised_headless do |app| options = Selenium::WebDriver::Options.chrome options.add_argument("--headless") options.add_argument("--no-sandbox") + options.add_argument("--window-size=1920,1080") # driver = Selenium::WebDriver.for :chrome, options: options From ea530754aa913e746c6c60c0cc071d529b515d14 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Sun, 10 Aug 2025 03:06:38 +0000 Subject: [PATCH 2/5] Disable dev shm usage on some environments --- spec/rails_helper.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index b85f2e627..779789d20 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -23,6 +23,7 @@ Capybara.register_driver :selenium_chrome_customised_headless do |app| options.add_argument("--headless") options.add_argument("--no-sandbox") options.add_argument("--window-size=1920,1080") + options.add_argument("--disable-dev-shm-usage") # driver = Selenium::WebDriver.for :chrome, options: options @@ -121,8 +122,8 @@ RSpec.configure do |config| # Prevent Poltergeist from fetching external URLs during feature tests config.before(:each, :js) do # TODO: Why are we setting this page size then straight afterwards, maximising? - width = 1280 - height = 1280 + width = 1920 + height = 1080 Capybara.current_session.driver.browser.manage.window.resize_to(width, height) if page.driver.browser.respond_to?(:url_blacklist) From d99d4a1bbe6109b5c0b586440fa676354b422b41 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Sun, 10 Aug 2025 03:08:57 +0000 Subject: [PATCH 3/5] Disable dev shm usage on some environments --- spec/rails_helper.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 779789d20..9f1f1805d 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -15,8 +15,6 @@ require 'capybara-screenshot/rspec' require 'axe-capybara' require 'axe-rspec' -# TODO: We may want to trial options.add_argument('--disable-dev-shm-usage') ### optional - # Required for running in the dev container Capybara.register_driver :selenium_chrome_customised_headless do |app| options = Selenium::WebDriver::Options.chrome From 7e3be99aacce08feee9654004d8d2170db5e8ca1 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Sun, 10 Aug 2025 03:12:58 +0000 Subject: [PATCH 4/5] Comment out and explain why --- spec/rails_helper.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 9f1f1805d..bd64cd333 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -132,6 +132,9 @@ RSpec.configure do |config| ] end - page.driver.browser.manage.window.maximize if page.driver.browser.respond_to?(:manage) + # Historically, we wanted to .maximize; but this actually undoes the resize_to step above + # with chrome headless + # page.driver.browser.manage.window.maximize if page.driver.browser.respond_to?(:manage) + # puts "Maximized window size: #{page.driver.browser.manage.window.size}" end end From ed7102330661f184be0bc9f40fb313483d0f301c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 10 Aug 2025 03:47:36 +0000 Subject: [PATCH 5/5] Bump rubocop from 1.79.1 to 1.79.2 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.79.1 to 1.79.2. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.79.1...v1.79.2) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.79.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 6ce46e85f..234508831 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -553,7 +553,7 @@ GEM recaptcha (5.19.0) redis-client (0.23.2) connection_pool - regexp_parser (2.11.0) + regexp_parser (2.11.1) reline (0.6.1) io-console (~> 0.5) responders (3.1.1) @@ -606,7 +606,7 @@ GEM rswag-ui (2.16.0) actionpack (>= 5.2, < 8.1) railties (>= 5.2, < 8.1) - rubocop (1.79.1) + rubocop (1.79.2) json (~> 2.3) language_server-protocol (~> 3.17.0.2) lint_roller (~> 1.1.0)