From 6383dbc19f368a523ddef63dbbe1717e54598047 Mon Sep 17 00:00:00 2001 From: Brenda Wallace Date: Thu, 11 Jul 2019 12:08:15 +1200 Subject: [PATCH] more percy specs --- spec/features/admin/admin_spec.rb | 16 ++++++++++++++++ .../comments/commenting_a_comment_spec.rb | 1 + spec/features/crops/alternate_name_spec.rb | 2 ++ spec/features/members/deletion_spec.rb | 1 + spec/features/notifications_spec.rb | 3 +++ spec/features/percy/percy_spec.rb | 5 ----- spec/features/photos/new_photo_spec.rb | 1 + spec/features/photos/show_photo_spec.rb | 1 + spec/features/places/searching_a_place_spec.rb | 1 + 9 files changed, 26 insertions(+), 5 deletions(-) create mode 100644 spec/features/admin/admin_spec.rb diff --git a/spec/features/admin/admin_spec.rb b/spec/features/admin/admin_spec.rb new file mode 100644 index 000000000..6ee586ee7 --- /dev/null +++ b/spec/features/admin/admin_spec.rb @@ -0,0 +1,16 @@ +require 'rails_helper' + +describe "forums", js: true do + context "as an admin user" do + let(:member) { create :admin_member } + + before do + login_as member + end + + it "navigating to forum admin with js" do + visit admin_path + Percy.snapshot(page, name: 'Admin page') + end + end +end diff --git a/spec/features/comments/commenting_a_comment_spec.rb b/spec/features/comments/commenting_a_comment_spec.rb index 2ab3fa615..f2136e98e 100644 --- a/spec/features/comments/commenting_a_comment_spec.rb +++ b/spec/features/comments/commenting_a_comment_spec.rb @@ -14,6 +14,7 @@ describe 'Commenting on a post' do click_button "Post comment" expect(page).to have_content "comment was successfully created." expect(page).to have_content "Posted by" + Percy.snapshot(page, name: 'Posting a comment') end context "editing a comment" do diff --git a/spec/features/crops/alternate_name_spec.rb b/spec/features/crops/alternate_name_spec.rb index cfb4bf3e3..903b6d3a7 100644 --- a/spec/features/crops/alternate_name_spec.rb +++ b/spec/features/crops/alternate_name_spec.rb @@ -34,6 +34,7 @@ describe "Alternate names", js: true do # expect(page.status_code).to equal 200 expect(page).to have_css "option[value='#{crop.id}'][selected=selected]" fill_in 'Name', with: "alternative aubergine" + Percy.snapshot(page, name: 'Crop wrangler adding alternate name') click_on "Save" # expect(page.status_code).to equal 200 expect(page).to have_content "alternative aubergine" @@ -77,6 +78,7 @@ describe "Alternate names", js: true do it "Displays crop rejection message" do visit alternate_name_path(pending_alt_name) expect(page).to have_content "This crop was rejected for the following reason: Totally fake" + Percy.snapshot(page, name: 'Rejecting crops') end end end diff --git a/spec/features/members/deletion_spec.rb b/spec/features/members/deletion_spec.rb index 7d5ac5972..5feb7014b 100644 --- a/spec/features/members/deletion_spec.rb +++ b/spec/features/members/deletion_spec.rb @@ -70,6 +70,7 @@ describe "member deletion" do visit member_path(member) click_link 'Edit profile' click_link 'Delete Account' + Percy.snapshot(page, name: 'Account deletion') fill_in "current_pw_for_delete", with: "password1", match: :prefer_exact click_button "Delete" logout diff --git a/spec/features/notifications_spec.rb b/spec/features/notifications_spec.rb index 77ac4ce38..4b2140d3f 100644 --- a/spec/features/notifications_spec.rb +++ b/spec/features/notifications_spec.rb @@ -37,6 +37,9 @@ describe "Notifications", :js do FactoryBot.create_list :notification, 34, recipient: recipient login_as recipient visit notifications_path + end + + it do Percy.snapshot(page, name: "notifications#index") end diff --git a/spec/features/percy/percy_spec.rb b/spec/features/percy/percy_spec.rb index 9bd59dd78..7b614d169 100644 --- a/spec/features/percy/percy_spec.rb +++ b/spec/features/percy/percy_spec.rb @@ -256,11 +256,6 @@ rest of the garden. end describe '#new' do - it 'plantings#new' do - visit new_planting_path - Percy.snapshot(page, name: "#{prefix}/plantings#new") - end - it 'crops#new' do visit new_crop_path Percy.snapshot(page, name: "#{prefix}/crops#new") diff --git a/spec/features/photos/new_photo_spec.rb b/spec/features/photos/new_photo_spec.rb index 8bf89fc7e..de0ae5664 100644 --- a/spec/features/photos/new_photo_spec.rb +++ b/spec/features/photos/new_photo_spec.rb @@ -18,6 +18,7 @@ describe "new photo page" do click_link('Add photo') end expect(page).to have_text planting.crop.name + Percy.snapshot(page, name: 'Add photo to planting') end end diff --git a/spec/features/photos/show_photo_spec.rb b/spec/features/photos/show_photo_spec.rb index a8d2ff802..2c027d57d 100644 --- a/spec/features/photos/show_photo_spec.rb +++ b/spec/features/photos/show_photo_spec.rb @@ -47,6 +47,7 @@ describe "show photo page" do before do garden.photos << photo visit photo_path(photo) + Percy.snapshot(page, name: 'Show photo of a garden') end it { expect(page).to have_link "garden named \"#{garden.name}\" by #{garden.owner}", href: garden_path(garden) } diff --git a/spec/features/places/searching_a_place_spec.rb b/spec/features/places/searching_a_place_spec.rb index 2db703c0a..fa64ea568 100644 --- a/spec/features/places/searching_a_place_spec.rb +++ b/spec/features/places/searching_a_place_spec.rb @@ -36,6 +36,7 @@ describe "User searches" do expect(page).to have_content "Nearby members" expect(page).to have_content "Seeds available for trade near Philippines" expect(page).to have_content "Recent plantings near Philippines" + Percy.snapshot(page, name: 'places map') end it "goes to members' index page" do