From fab9560c46c945092b539e05d8983f59faddba3e Mon Sep 17 00:00:00 2001
From: Brenda Wallace <brenda@wallace.net.nz>
Date: Sun, 22 Sep 2019 13:22:02 +1200
Subject: [PATCH] Apply suggestions from code review

---
 app/models/crop.rb      | 2 +-
 app/models/crop_post.rb | 2 +-
 app/models/post.rb      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/models/crop.rb b/app/models/crop.rb
index b639ed9d7..857b8e132 100644
--- a/app/models/crop.rb
+++ b/app/models/crop.rb
@@ -18,7 +18,7 @@ class Crop < ApplicationRecord
   belongs_to :requester, class_name: 'Member', optional: true, inverse_of: :requested_crops
   belongs_to :parent, class_name: 'Crop', optional: true, inverse_of: :varieties
   has_many :varieties, class_name: 'Crop', foreign_key: 'parent_id', dependent: :nullify, inverse_of: :parent
-  has_many :crop_posts
+  has_many :crop_posts, dependent: :delete_all
   has_many :posts, through: :crop_posts, dependent: :delete_all
 
   ##
diff --git a/app/models/crop_post.rb b/app/models/crop_post.rb
index 8aaa15214..5c520e3b6 100644
--- a/app/models/crop_post.rb
+++ b/app/models/crop_post.rb
@@ -1,4 +1,4 @@
 class CropPost < ApplicationRecord
   belongs_to :crop
   belongs_to :post
-end
\ No newline at end of file
+end
diff --git a/app/models/post.rb b/app/models/post.rb
index c706fb18f..b2a8b88fd 100644
--- a/app/models/post.rb
+++ b/app/models/post.rb
@@ -64,7 +64,7 @@ class Post < ApplicationRecord
       crop_name = Regexp.last_match(1)
       crop = Crop.case_insensitive_name(crop_name).first
       # create association
-      self.crops << crop if crop && !crops.include?(crop)
+      crops << crop if crop && !crops.include?(crop)
     end
   end