diff --git a/spec/controllers/api/v1/plantings_controller_spec.rb b/spec/controllers/api/v1/plantings_controller_spec.rb index 57b450d94..c187e1213 100644 --- a/spec/controllers/api/v1/plantings_controller_spec.rb +++ b/spec/controllers/api/v1/plantings_controller_spec.rb @@ -5,12 +5,6 @@ require 'rails_helper' RSpec.describe Api::V1::PlantingsController, type: :controller do subject { JSON.parse response.body } - let(:headers) do - { - 'Accept' => 'application/vnd.api+json', - 'Content-Type' => 'application/vnd.api+json' - } - end let!(:member) { FactoryBot.create :member } describe '#index' do diff --git a/spec/controllers/charts/gardens_controller_spec.rb b/spec/controllers/charts/gardens_controller_spec.rb index 250b05358..1eb959b29 100644 --- a/spec/controllers/charts/gardens_controller_spec.rb +++ b/spec/controllers/charts/gardens_controller_spec.rb @@ -2,7 +2,6 @@ require 'rails_helper' describe Charts::GardensController do include Devise::Test::ControllerHelpers - let(:valid_params) { { name: 'My second Garden' } } let(:garden) { FactoryBot.create :garden } diff --git a/spec/controllers/garden_types_controller_spec.rb b/spec/controllers/garden_types_controller_spec.rb index 73e59d176..53bc9cae8 100644 --- a/spec/controllers/garden_types_controller_spec.rb +++ b/spec/controllers/garden_types_controller_spec.rb @@ -5,9 +5,6 @@ RSpec.describe GardenTypesController, type: :controller do let(:valid_params) { { name: 'My second GardenType' } } let(:garden_type) { FactoryBot.create :garden_type } - let(:member) { FactoryBot.create(:member) } - let(:admin_member) { FactoryBot.create(:admin) } - context "when not signed in" do describe 'GET new' do before { get :new, params: { id: garden_type.to_param } } diff --git a/spec/controllers/likes_controller_spec.rb b/spec/controllers/likes_controller_spec.rb index 5527a595e..6730b0a8f 100644 --- a/spec/controllers/likes_controller_spec.rb +++ b/spec/controllers/likes_controller_spec.rb @@ -4,7 +4,6 @@ describe LikesController do let(:like) { FactoryBot.create :like, member: member } let(:member) { FactoryBot.create(:member) } let(:blogpost) { FactoryBot.create(:post) } - let(:mypost) { FactoryBot.create(:post, author: member) } before { sign_in member } @@ -22,7 +21,6 @@ describe LikesController do end describe "Liking your own post" do - let(:blogpost) { FactoryBot.create(:post, author: member) } end end diff --git a/spec/features/crops/scientific_name_spec.rb b/spec/features/crops/scientific_name_spec.rb index 3b525c5c3..a5f206fdd 100644 --- a/spec/features/crops/scientific_name_spec.rb +++ b/spec/features/crops/scientific_name_spec.rb @@ -18,7 +18,6 @@ describe "Scientific names", js: true do context "User is a crop wrangler" do let!(:crop_wranglers) { create_list :crop_wrangling_member, 3 } - let(:member) { crop_wranglers.first } include_context 'signed in crop wrangler' do it "Crop wranglers can edit scientific names" do diff --git a/spec/features/crops/show_spec.rb b/spec/features/crops/show_spec.rb index bfab353a4..f6fb15410 100644 --- a/spec/features/crops/show_spec.rb +++ b/spec/features/crops/show_spec.rb @@ -1,10 +1,7 @@ require 'rails_helper' describe "browse crops" do - let(:tomato) { create :tomato } - let(:maize) { create :maize } - let(:pending_crop) { create :crop_request } - let(:rejected_crop) { create :rejected_crop } + let(:tomato) { create :tomato } it "Show crop info" do visit crop_path(tomato) diff --git a/spec/features/harvests/harvesting_a_crop_spec.rb b/spec/features/harvests/harvesting_a_crop_spec.rb index d3ded52e1..7ad9a285a 100644 --- a/spec/features/harvests/harvesting_a_crop_spec.rb +++ b/spec/features/harvests/harvesting_a_crop_spec.rb @@ -4,8 +4,7 @@ require 'custom_matchers' describe "Harvesting a crop", :js, :elasticsearch do include_context 'signed in member' do let!(:maize) { create :maize } - let!(:plant_part) { create :plant_part } - let(:planting) { create :planting, crop: maize, owner: member } + let!(:plant_part) { create :plant_part } before { visit new_harvest_path } diff --git a/spec/features/likeable_spec.rb b/spec/features/likeable_spec.rb index 767bffa07..b2527402a 100644 --- a/spec/features/likeable_spec.rb +++ b/spec/features/likeable_spec.rb @@ -1,7 +1,6 @@ require 'rails_helper' describe 'Likeable', js: true do - let(:member) { FactoryBot.create(:member) } let(:another_member) { FactoryBot.create(:london_member) } let!(:post) { FactoryBot.create(:post, author: member) } let!(:photo) { FactoryBot.create(:photo, owner: member) } diff --git a/spec/features/members/deletion_spec.rb b/spec/features/members/deletion_spec.rb index 35326a0c9..ce3ff7769 100644 --- a/spec/features/members/deletion_spec.rb +++ b/spec/features/members/deletion_spec.rb @@ -10,7 +10,6 @@ describe "member deletion" do let!(:harvest) { FactoryBot.create(:harvest, owner: member) } let!(:seed) { FactoryBot.create(:seed, owner: member) } let!(:secondgarden) { FactoryBot.create(:garden, owner: member) } - let(:admin) { FactoryBot.create(:admin_member) } before do login_as(member) diff --git a/spec/features/percy/percy_spec.rb b/spec/features/percy/percy_spec.rb index 6d0a48a3a..01b32539a 100644 --- a/spec/features/percy/percy_spec.rb +++ b/spec/features/percy/percy_spec.rb @@ -340,7 +340,6 @@ rest of the garden. context 'wrangling crops' do include_context 'signed in crop wrangler' do - let(:prefix) { 'crop-wrangler' } let!(:candy) { FactoryBot.create :crop_request, name: 'candy' } it 'crop wrangling page' do diff --git a/spec/features/photos/new_photo_spec.rb b/spec/features/photos/new_photo_spec.rb index 4bf64065e..93e3a155c 100644 --- a/spec/features/photos/new_photo_spec.rb +++ b/spec/features/photos/new_photo_spec.rb @@ -1,11 +1,7 @@ require 'rails_helper' describe "new photo page" do - let(:photo) { FactoryBot.create :photo } - context "signed in member" do - let(:member) { FactoryBot.create :member } - include_context 'signed in member' do context "viewing a planting" do let(:planting) { FactoryBot.create :planting, owner: member } diff --git a/spec/features/photos/show_photo_spec.rb b/spec/features/photos/show_photo_spec.rb index 664b24aee..779270b0e 100644 --- a/spec/features/photos/show_photo_spec.rb +++ b/spec/features/photos/show_photo_spec.rb @@ -2,8 +2,6 @@ require 'rails_helper' describe "show photo page" do context "signed in member" do - let(:member) { create :member } - include_context 'signed in member' do context "linked to planting" do let(:planting) { create :planting } diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb index 8ff4b2d96..39ee86bd0 100644 --- a/spec/features/plantings/planting_a_crop_spec.rb +++ b/spec/features/plantings/planting_a_crop_spec.rb @@ -2,7 +2,6 @@ require "rails_helper" require 'custom_matchers' describe "Planting a crop", :js, :elasticsearch do - let(:member) { FactoryBot.create :member } let!(:maize) { FactoryBot.create :maize } let(:garden) { FactoryBot.create :garden, owner: member } let!(:planting) do diff --git a/spec/features/seeds/misc_seeds_spec.rb b/spec/features/seeds/misc_seeds_spec.rb index 467c1acb3..33c8576c7 100644 --- a/spec/features/seeds/misc_seeds_spec.rb +++ b/spec/features/seeds/misc_seeds_spec.rb @@ -1,11 +1,7 @@ require 'rails_helper' describe "seeds", js: true do - let(:member) { create :member } - context "signed in user" do - let(:crop) { create :crop } - include_context 'signed in member' do xit "button on index to edit seed" do let!(:seed) { create :seed, owner: member } diff --git a/spec/features/shared_examples/append_date.rb b/spec/features/shared_examples/append_date.rb index 6f6247736..8dc283c22 100644 --- a/spec/features/shared_examples/append_date.rb +++ b/spec/features/shared_examples/append_date.rb @@ -1,6 +1,5 @@ shared_examples "append date" do let(:this_month) { Time.zone.today.strftime("%b") } - let(:this_year) { Time.zone.today.strftime("%Y") } before { visit path } diff --git a/spec/features/signin_spec.rb b/spec/features/signin_spec.rb index dd7526549..55e31d4b9 100644 --- a/spec/features/signin_spec.rb +++ b/spec/features/signin_spec.rb @@ -4,7 +4,6 @@ describe "signin", js: true do let(:member) { FactoryBot.create :member } let(:recipient) { FactoryBot.create :member } let(:wrangler) { FactoryBot.create :crop_wrangling_member } - let(:notification) { FactoryBot.create :notification, recipient: recipient } def login fill_in 'Login', with: member.login_name diff --git a/spec/features/signout_spec.rb b/spec/features/signout_spec.rb index c94221b1e..d65370ff6 100644 --- a/spec/features/signout_spec.rb +++ b/spec/features/signout_spec.rb @@ -3,8 +3,6 @@ require 'rails_helper' describe "signout" do let(:member) { create :member } - let(:path) {} - it "redirect to previous page after signout" do visit crops_path # some random page click_link 'Sign in' diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb index 687219386..75166df9f 100644 --- a/spec/models/comment_spec.rb +++ b/spec/models/comment_spec.rb @@ -14,8 +14,6 @@ describe Comment do end context "notifications" do - let(:comment) { FactoryBot.create(:comment) } - it "sends a notification when a comment is posted" do expect do FactoryBot.create(:comment) diff --git a/spec/models/crop_spec.rb b/spec/models/crop_spec.rb index ed17069c9..4b775b4ef 100644 --- a/spec/models/crop_spec.rb +++ b/spec/models/crop_spec.rb @@ -1,9 +1,6 @@ require 'rails_helper' describe Crop do - let(:pp2) { FactoryBot.create(:plant_part) } - let(:pp1) { FactoryBot.create(:plant_part) } - let(:maize) { FactoryBot.create(:maize) } context 'all fields present' do let(:crop) { FactoryBot.create(:tomato) } @@ -50,7 +47,6 @@ describe Crop do context 'popularity' do let(:tomato) { FactoryBot.create(:tomato) } let(:maize) { FactoryBot.create(:maize) } - let(:cucumber) { FactoryBot.create(:crop, name: 'cucumber') } before do FactoryBot.create_list(:planting, 10, crop: maize) @@ -145,8 +141,7 @@ describe Crop do shared_examples 'has default photo' do it { expect(Crop.has_photos).to include(crop) } end - let!(:crop) { FactoryBot.create :tomato } - let(:member) { FactoryBot.create :member } + let!(:crop) { FactoryBot.create :tomato } context 'with a planting photo' do let!(:photo) { FactoryBot.create(:photo, owner: planting.owner) } @@ -296,7 +291,6 @@ describe Crop do context 'interesting' do subject { Crop.interesting } - let(:photo) { FactoryBot.create :photo } # first, a couple of candidate crops let(:crop1) { FactoryBot.create(:crop) } let(:crop2) { FactoryBot.create(:crop) } @@ -349,13 +343,7 @@ describe Crop do end end - let(:maize) { FactoryBot.create(:maize) } - let(:pp1) { FactoryBot.create(:plant_part) } - let(:pp2) { FactoryBot.create(:plant_part) } - context "harvests" do - let(:h1) { FactoryBot.create(:harvest, crop: maize, plant_part: pp1) } - let(:h2) { FactoryBot.create(:harvest, crop: maize, plant_part: pp2) } let!(:crop) { FactoryBot.create(:crop) } let!(:harvest) { FactoryBot.create(:harvest, crop: crop) } diff --git a/spec/models/garden_spec.rb b/spec/models/garden_spec.rb index 522a9bfc1..a6e0b12fb 100644 --- a/spec/models/garden_spec.rb +++ b/spec/models/garden_spec.rb @@ -3,7 +3,6 @@ require 'rails_helper' describe Garden do let(:owner) { FactoryBot.create(:member, login_name: 'hatupatu') } let(:garden) { FactoryBot.create(:garden, owner: owner, name: 'Springfield Community Garden') } - let(:garden_type) { FactoryBot.create(:garden_type, name: "aquaponic") } it "has a slug" do garden.slug.should match(/hatupatu-springfield-community-garden/) diff --git a/spec/models/planting_spec.rb b/spec/models/planting_spec.rb index 32d3da008..56e477f4f 100644 --- a/spec/models/planting_spec.rb +++ b/spec/models/planting_spec.rb @@ -5,9 +5,6 @@ describe Planting do let(:garden_owner) { FactoryBot.create(:member, login_name: 'hatupatu') } let(:garden) { FactoryBot.create(:garden, owner: garden_owner, name: 'Springfield Community Garden') } let(:planting) { FactoryBot.create(:planting, crop: crop, garden: garden, owner: garden.owner) } - let(:finished_planting) do - FactoryBot.create :planting, planted_at: 4.days.ago, finished_at: 2.days.ago, finished: true - end describe 'planting lifespan predictions' do context 'no predications data yet' do