diff --git a/Gemfile b/Gemfile index 635433d2f..522a0c158 100644 --- a/Gemfile +++ b/Gemfile @@ -33,7 +33,7 @@ gem "bootstrap", ">= 5.0.0" gem 'material_icons' # icons -gem 'font-awesome-sass' +gem 'font-awesome-sass', '~> 6.7' gem 'terser' diff --git a/Gemfile.lock b/Gemfile.lock index 229b3dcc9..9763e67ff 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -276,8 +276,8 @@ GEM ffi (1.17.4) ffi (1.17.4-x86_64-linux-gnu) flickraw (0.9.10) - font-awesome-sass (5.15.1) - sassc (>= 1.11) + font-awesome-sass (6.7.2) + sassc (~> 2.0) friendly_id (5.7.0) activerecord (>= 4.0.0) gbifrb (0.2.0) @@ -793,7 +793,7 @@ DEPENDENCIES faker faraday flickraw - font-awesome-sass + font-awesome-sass (~> 6.7) friendly_id gbifrb geocoder diff --git a/app/assets/stylesheets/_garden_cards.scss b/app/assets/stylesheets/_garden_cards.scss index 097bc60e0..e3fb60c3c 100644 --- a/app/assets/stylesheets/_garden_cards.scss +++ b/app/assets/stylesheets/_garden_cards.scss @@ -120,7 +120,10 @@ $garden-card-line: #e6e6e6; background: none; cursor: pointer; - .fa { + // The icon, whatever style prefix it carries. Keyed on the element rather + // than .fa, which stopped matching when Font Awesome 6 dropped the bare + // prefix and every icon became .fas, .far or .fab. + i { margin-left: 0.35rem; opacity: 0.5; } @@ -129,7 +132,7 @@ $garden-card-line: #e6e6e6; &:focus-visible { color: var(--bs-link-color, #0a58ca); - .fa { + i { opacity: 1; } } diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss index 209a832da..8fe464074 100644 --- a/app/assets/stylesheets/application.scss +++ b/app/assets/stylesheets/application.scss @@ -9,8 +9,13 @@ @import "leaflet.markercluster/dist/MarkerCluster"; @import "leaflet.markercluster/dist/MarkerCluster.Default"; -// Font Awesome -@import "font-awesome-sprockets"; +// Font Awesome. The 6.x gem dropped its _font-awesome-sprockets.scss but its +// @font-face rules still call fa-font-path(), so we define it here against +// Sprockets' font-path helper. Its fonts live under assets/fonts/font-awesome. +@function fa-font-path($path) { + @return font-path("font-awesome/#{$path}"); +} + @import "font-awesome"; @import "material_icons"; @import "rails_bootstrap_forms"; diff --git a/app/helpers/icons_helper.rb b/app/helpers/icons_helper.rb index 80c118d00..e51f398a8 100644 --- a/app/helpers/icons_helper.rb +++ b/app/helpers/icons_helper.rb @@ -76,7 +76,7 @@ module IconsHelper end def activity_icon - icon('fas', 'fa-truck-pickup') + icon('fas', 'truck-pickup') end def post_icon diff --git a/app/javascript/components/AddPhotoModal.jsx b/app/javascript/components/AddPhotoModal.jsx index c8e8f4590..60288a36e 100644 --- a/app/javascript/components/AddPhotoModal.jsx +++ b/app/javascript/components/AddPhotoModal.jsx @@ -141,7 +141,7 @@ export default function AddPhotoModal({label, newUrl, iconUrl, onClose, onAdded} )} {!loadError && !data && ( -