diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cb0b978f6..ba60a33d0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -26,12 +26,6 @@ Lint/AmbiguousRegexpLiteral: - 'spec/views/members/show.rss.haml_spec.rb' - 'spec/views/posts/show.html.haml_spec.rb' -# Offense count: 1 -# Configuration parameters: AllowSafeAssignment. -Lint/AssignmentInCondition: - Exclude: - - 'app/models/member.rb' - # Offense count: 1 Lint/HandleExceptions: Exclude: diff --git a/app/models/member.rb b/app/models/member.rb index 931a73402..598507063 100644 --- a/app/models/member.rb +++ b/app/models/member.rb @@ -91,11 +91,9 @@ class Member < ActiveRecord::Base # allow login via either login_name or email address def self.find_first_by_auth_conditions(warden_conditions) conditions = warden_conditions.dup - if login = conditions.delete(:login) - where(conditions).login_name_or_email(login).first - else - find_by(conditions) - end + login = conditions.delete(:login) + return where(conditions).login_name_or_email(login).first if login + find_by(conditions) end def to_s