From b0d4f9c731e44152fc103d713f6e46f9e55d44f1 Mon Sep 17 00:00:00 2001 From: Mackenzie Morgan Date: Thu, 23 Jul 2015 13:56:07 -0400 Subject: [PATCH 1/3] switch homepage and members/ page member thumbnails to be a flexbox layout so it's more responsive. Fixes #780 --- app/assets/stylesheets/overrides.css.less | 21 ++++++++++++--- app/views/home/_members.html.haml | 6 ++--- app/views/members/_thumbnail.html.haml | 31 +++++++++++------------ app/views/members/index.html.haml | 6 ++--- 4 files changed, 37 insertions(+), 27 deletions(-) diff --git a/app/assets/stylesheets/overrides.css.less b/app/assets/stylesheets/overrides.css.less index 5be07c494..bf1943fd1 100644 --- a/app/assets/stylesheets/overrides.css.less +++ b/app/assets/stylesheets/overrides.css.less @@ -97,12 +97,25 @@ p.stats { font-weight: bold; } -.homepage-members { - height: 100px; +.member-cards { + display: flex; + flex: none; + flex-wrap: wrap; + justify-content: space-between; } +.member-thumbnail { + padding: .25em; -.homepage-members:nth-child(odd) { - margin-left: 0px; + div { + width: 5em; + display: inline-block; + vertical-align: top; + } + + div ~ div { + width: 15em; + padding-left: 1em; + } } #placesmap, #cropmap { diff --git a/app/views/home/_members.html.haml b/app/views/home/_members.html.haml index cca5829d6..aea526c21 100644 --- a/app/views/home/_members.html.haml +++ b/app/views/home/_members.html.haml @@ -2,12 +2,12 @@ .hidden-xs - members = Member.interesting.first(6) - if members.present? + %section %h2= t('.title') - .row + .member-cards - members.each do |m| - .col-md-4.homepage-members - = render :partial => "members/thumbnail", :locals => { :member => m } + = render :partial => "members/thumbnail", :locals => { :member => m } %p.text-right = link_to "#{t('.view_all')} ยป", members_path diff --git a/app/views/members/_thumbnail.html.haml b/app/views/members/_thumbnail.html.haml index c90faba8a..5f0f9c58d 100644 --- a/app/views/members/_thumbnail.html.haml +++ b/app/views/members/_thumbnail.html.haml @@ -1,17 +1,16 @@ - cache member do - .row - .member-thumbnail - .col-md-3 - = render :partial => "members/image_with_popover", :locals => { :member => member } - .col-md-9 - %p - = link_to member.login_name, member - - if ! member.location.blank? - %small - %br/ - %i= member.location - - if ! member.plantings.empty? - %small - %br/ - Recently planted: - != member.plantings.first(3).map{|p| link_to p.crop_name, p }.join(", ") + .member-thumbnail.panel + %div + = render :partial => "members/image_with_popover", :locals => { :member => member } + %div + %p + = link_to member.login_name, member + - if ! member.location.blank? + %small + %br/ + %i= member.location + - if ! member.plantings.empty? + %small + %br/ + Recently planted: + != member.plantings.first(3).map{|p| link_to p.crop_name, p }.join(", ") diff --git a/app/views/members/index.html.haml b/app/views/members/index.html.haml index 36ba70887..0fa659ede 100644 --- a/app/views/members/index.html.haml +++ b/app/views/members/index.html.haml @@ -10,11 +10,9 @@ = page_entries_info @members, :model => "members" = will_paginate @members -.row +.member-cards - @members.each do |m| - .col-md-4.three-across - .thumbnail - = render :partial => "members/thumbnail", :locals => { :member => m } + = render :partial => "members/thumbnail", :locals => { :member => m } %div.pagination = page_entries_info @members, :model => "members" From e3738ca0c67ef6808d207b2c4ebcabcf2161e39f Mon Sep 17 00:00:00 2001 From: Mackenzie Morgan Date: Thu, 23 Jul 2015 13:56:23 -0400 Subject: [PATCH 2/3] whitespace tab/space correction --- app/helpers/gardens_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/gardens_helper.rb b/app/helpers/gardens_helper.rb index b4fb49d06..dfd0a2582 100644 --- a/app/helpers/gardens_helper.rb +++ b/app/helpers/gardens_helper.rb @@ -1,7 +1,7 @@ module GardensHelper def display_garden_description(garden) - if garden.description.nil? + if garden.description.nil? "no description provided." else truncate(garden.description, length: 130, separator: ' ', omission: '... ') { link_to "Read more", garden_path(garden) } From f970fc4db27628a8107ebcbba0e6063b977e27d8 Mon Sep 17 00:00:00 2001 From: Miles Gould Date: Fri, 24 Jul 2015 11:09:22 +0100 Subject: [PATCH 3/3] Fix another whitespace problem. --- app/helpers/gardens_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/gardens_helper.rb b/app/helpers/gardens_helper.rb index dfd0a2582..57f0c7bc6 100644 --- a/app/helpers/gardens_helper.rb +++ b/app/helpers/gardens_helper.rb @@ -2,7 +2,7 @@ module GardensHelper def display_garden_description(garden) if garden.description.nil? - "no description provided." + "no description provided." else truncate(garden.description, length: 130, separator: ' ', omission: '... ') { link_to "Read more", garden_path(garden) } end