From dfa963cd653cbecafb359d945941989e4c984d68 Mon Sep 17 00:00:00 2001 From: Daniel O'Connor Date: Sun, 26 Apr 2026 03:18:50 +0930 Subject: [PATCH] Rubocop: RSpec/EmptyExampleGroup (#4554) * Rubocop: RSpec/EmptyExampleGroup * Undo renaming * Apply suggestion from @CloCkWeRX * Apply suggestion from @CloCkWeRX --- .rubocop_todo.yml | 13 ------------- .../authentications_controller_spec.rb | 18 ------------------ spec/controllers/forums_controller_spec.rb | 19 ------------------- spec/controllers/seeds_controller_spec.rb | 4 ---- .../plantings/planting_a_crop_spec.rb | 4 ++-- spec/views/home/index_spec.rb | 8 -------- spec/views/photos/edit.html.haml_spec.rb | 13 ------------- spec/views/posts/_single.html.haml_spec.rb | 10 ---------- 8 files changed, 2 insertions(+), 87 deletions(-) delete mode 100644 spec/controllers/authentications_controller_spec.rb delete mode 100644 spec/controllers/forums_controller_spec.rb delete mode 100644 spec/views/photos/edit.html.haml_spec.rb diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 73ee1f0a3..0d7578d78 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -242,18 +242,6 @@ RSpec/DescribedClass: - 'spec/models/member_spec.rb' - 'spec/services/timeline_service_spec.rb' -# Offense count: 7 -# This cop supports unsafe autocorrection (--autocorrect-all). -RSpec/EmptyExampleGroup: - Exclude: - - 'spec/controllers/authentications_controller_spec.rb' - - 'spec/controllers/forums_controller_spec.rb' - - 'spec/controllers/seeds_controller_spec.rb' - - 'spec/features/plantings/planting_a_crop_spec.rb' - - 'spec/views/home/index_spec.rb' - - 'spec/views/photos/edit.html.haml_spec.rb' - - 'spec/views/posts/_single.html.haml_spec.rb' - # Offense count: 146 # Configuration parameters: CountAsOne. RSpec/ExampleLength: @@ -318,7 +306,6 @@ RSpec/IndexedLet: - 'spec/features/percy/percy_spec.rb' - 'spec/features/planting_reminder_spec.rb' - 'spec/features/timeline/index_spec.rb' - - 'spec/models/crop_spec.rb' - 'spec/models/member_spec.rb' - 'spec/views/forums/index.html.haml_spec.rb' diff --git a/spec/controllers/authentications_controller_spec.rb b/spec/controllers/authentications_controller_spec.rb deleted file mode 100644 index 3dc67f2f1..000000000 --- a/spec/controllers/authentications_controller_spec.rb +++ /dev/null @@ -1,18 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -describe AuthenticationsController do - before do - @member = create(:member) - sign_in @member - controller.stub(:current_member) { @member } - @auth = create(:authentication, member: @member) - request.env['omniauth.auth'] = { - 'provider' => 'foo', - 'uid' => 'bar', - 'info' => { 'nickname' => 'blah' }, - 'credentials' => { 'token' => 'blah', 'secret' => 'blah' } - } - end -end diff --git a/spec/controllers/forums_controller_spec.rb b/spec/controllers/forums_controller_spec.rb deleted file mode 100644 index 2e7869c1f..000000000 --- a/spec/controllers/forums_controller_spec.rb +++ /dev/null @@ -1,19 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -describe ForumsController do - login_member(:admin_member) - - def valid_attributes - { - "name" => "MyString", - "description" => "Something", - "owner_id" => 1 - } - end - - def valid_session - {} - end -end diff --git a/spec/controllers/seeds_controller_spec.rb b/spec/controllers/seeds_controller_spec.rb index a5b0796a1..9ae4b5863 100644 --- a/spec/controllers/seeds_controller_spec.rb +++ b/spec/controllers/seeds_controller_spec.rb @@ -21,10 +21,6 @@ describe SeedsController, :search do it { expect(response).to be_successful } - context 'no parent planting' do - before { get :new } - end - context 'with parent planting' do let!(:planting) { create(:planting, owner:) } diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb index 981a7b2fa..1a17ba405 100644 --- a/spec/features/plantings/planting_a_crop_spec.rb +++ b/spec/features/plantings/planting_a_crop_spec.rb @@ -286,9 +286,9 @@ describe "Planting a crop", :js, :search do check "Mark as finished" click_button "Save" end - - it { expect(page).to have_css("img[alt='sun']") } end + + xit { expect(page).to have_css("img[alt='sun']") } end describe "Marking a planting as finished from the show page" do diff --git a/spec/views/home/index_spec.rb b/spec/views/home/index_spec.rb index ae6eabadb..dcf074168 100644 --- a/spec/views/home/index_spec.rb +++ b/spec/views/home/index_spec.rb @@ -33,12 +33,4 @@ describe 'home/index.html.haml', type: "view" do rendered.should have_content @member.location end end - - context 'signed in' do - before do - sign_in @member - controller.stub(:current_user) { @member } - render - end - end end diff --git a/spec/views/photos/edit.html.haml_spec.rb b/spec/views/photos/edit.html.haml_spec.rb deleted file mode 100644 index a954b84c1..000000000 --- a/spec/views/photos/edit.html.haml_spec.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -describe "photos/edit" do - before do - @photo = assign(:photo, stub_model(Photo, - owner_id: 1, - flickr_photo_id: 1, - thumbnail_url: "MyString", - fullsize_url: "MyString")) - end -end diff --git a/spec/views/posts/_single.html.haml_spec.rb b/spec/views/posts/_single.html.haml_spec.rb index f6ae1db00..d7a54cd14 100644 --- a/spec/views/posts/_single.html.haml_spec.rb +++ b/spec/views/posts/_single.html.haml_spec.rb @@ -43,16 +43,6 @@ describe "posts/_single" do end end - context "when logged in as post author" do - before do - @member = create(:member) - sign_in @member - controller.stub(:current_user) { @member } - @post = create(:post, author: @member) - render_post - end - end - context "when post has been edited" do before do @member = create(:member)